From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtfnW-0007KS-CA for qemu-devel@nongnu.org; Wed, 26 Nov 2014 11:50:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtfnQ-0003pq-2r for qemu-devel@nongnu.org; Wed, 26 Nov 2014 11:50:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52996) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtfnP-0003pl-Rz for qemu-devel@nongnu.org; Wed, 26 Nov 2014 11:50:28 -0500 From: Stefan Hajnoczi Date: Wed, 26 Nov 2014 16:50:16 +0000 Message-Id: <1417020616-21654-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH for-2.3] softmmu: clarify meaning of TLB_NOTDIRTY bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Stefan Hajnoczi , rth@twiddle.net It wasn't obvious to me why the TLB entries should cache the memory dirty bitmap state. Signed-off-by: Stefan Hajnoczi --- include/exec/cpu-all.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h index c085804..e71e47e 100644 --- a/include/exec/cpu-all.h +++ b/include/exec/cpu-all.h @@ -329,7 +329,8 @@ extern RAMList ram_list; /* Zero if TLB entry is valid. */ #define TLB_INVALID_MASK (1 << 3) /* Set if TLB entry references a clean RAM page. The iotlb entry will - contain the page physical address. */ + contain the page physical address. Forces us to take the slow path so pages + get marked dirty, whereas the fast path does not mark pages dirty. */ #define TLB_NOTDIRTY (1 << 4) /* Set if TLB entry is an IO callback. */ #define TLB_MMIO (1 << 5) -- 2.1.0