From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48597) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xu0Nf-0000nd-5i for qemu-devel@nongnu.org; Thu, 27 Nov 2014 09:49:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xu0Na-0003bo-3l for qemu-devel@nongnu.org; Thu, 27 Nov 2014 09:49:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48872) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xu0NZ-0003bh-S4 for qemu-devel@nongnu.org; Thu, 27 Nov 2014 09:49:10 -0500 From: Max Reitz Date: Thu, 27 Nov 2014 15:48:39 +0100 Message-Id: <1417099720-16428-13-git-send-email-mreitz@redhat.com> In-Reply-To: <1417099720-16428-1-git-send-email-mreitz@redhat.com> References: <1417099720-16428-1-git-send-email-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH v2 12/13] qcow2: Respect bdrv_truncate() error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Lieven , Markus Armbruster , Max Reitz , Stefan Hajnoczi bdrv_truncate() may fail and qcow2_write_compressed() should return the error code in that case. Cc: qemu-stable@nongnu.org Signed-off-by: Max Reitz --- block/qcow2.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 41f896f..7a28169 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -2163,8 +2163,7 @@ static int qcow2_write_compressed(BlockDriverState *bs, int64_t sector_num, /* align end of file to a sector boundary to ease reading with sector based I/Os */ cluster_offset = bdrv_getlength(bs->file); - bdrv_truncate(bs->file, cluster_offset); - return 0; + return bdrv_truncate(bs->file, cluster_offset); } if (nb_sectors != s->cluster_sectors) { -- 1.9.3