From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xu0Nh-0000rl-9A for qemu-devel@nongnu.org; Thu, 27 Nov 2014 09:49:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xu0Nb-0003cf-90 for qemu-devel@nongnu.org; Thu, 27 Nov 2014 09:49:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40302) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xu0Nb-0003cO-2d for qemu-devel@nongnu.org; Thu, 27 Nov 2014 09:49:11 -0500 From: Max Reitz Date: Thu, 27 Nov 2014 15:48:40 +0100 Message-Id: <1417099720-16428-14-git-send-email-mreitz@redhat.com> In-Reply-To: <1417099720-16428-1-git-send-email-mreitz@redhat.com> References: <1417099720-16428-1-git-send-email-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH v2 13/13] block/raw-posix: Fix ret in raw_open_common() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Lieven , Markus Armbruster , Max Reitz , Stefan Hajnoczi The return value must be negative on error; there is one place in raw_open_common() where errp is set, but ret remains 0. Fix it. Cc: qemu-stable@nongnu.org Signed-off-by: Max Reitz --- block/raw-posix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/raw-posix.c b/block/raw-posix.c index 6766cec..49d05d5 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -446,6 +446,7 @@ static int raw_open_common(BlockDriverState *bs, QDict *options, } if (fstat(s->fd, &st) < 0) { + ret = -errno; error_setg_errno(errp, errno, "Could not stat file"); goto fail; } -- 1.9.3