From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Lieven <pl@kamp.de>,
Markus Armbruster <armbru@redhat.com>,
Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH v2 03/13] block/vvfat: qcow driver may not be found
Date: Thu, 27 Nov 2014 15:48:30 +0100 [thread overview]
Message-ID: <1417099720-16428-4-git-send-email-mreitz@redhat.com> (raw)
In-Reply-To: <1417099720-16428-1-git-send-email-mreitz@redhat.com>
Although virtually impossible right now, bdrv_find_format("qcow") may
fail. The vvfat block driver should heed that case.
Cc: qemu-stable@nongnu.org
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
block/vvfat.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/block/vvfat.c b/block/vvfat.c
index cefe3a4..e34a789 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -2917,6 +2917,12 @@ static int enable_write_target(BDRVVVFATState *s, Error **errp)
}
bdrv_qcow = bdrv_find_format("qcow");
+ if (!bdrv_qcow) {
+ error_setg(errp, "Failed to locate qcow driver");
+ ret = -ENOENT;
+ goto err;
+ }
+
opts = qemu_opts_create(bdrv_qcow->create_opts, NULL, 0, &error_abort);
qemu_opt_set_number(opts, BLOCK_OPT_SIZE, s->sector_count * 512);
qemu_opt_set(opts, BLOCK_OPT_BACKING_FILE, "fat:");
--
1.9.3
next prev parent reply other threads:[~2014-11-27 14:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 14:48 [Qemu-devel] [PATCH v2 00/13] block: Various Coverity-spotted fixes Max Reitz
2014-11-27 14:48 ` [Qemu-devel] [PATCH v2 01/13] block: Make essential BlockDriver objects public Max Reitz
2014-12-01 15:59 ` Eric Blake
2014-12-02 9:11 ` Max Reitz
2014-12-02 16:45 ` Eric Blake
2014-12-02 10:51 ` Kevin Wolf
2014-11-27 14:48 ` [Qemu-devel] [PATCH v2 02/13] block: Omit bdrv_find_format for essential drivers Max Reitz
2014-12-01 16:01 ` Eric Blake
2014-12-02 9:12 ` Max Reitz
2014-11-27 14:48 ` Max Reitz [this message]
2014-12-02 10:57 ` [Qemu-devel] [PATCH v2 03/13] block/vvfat: qcow driver may not be found Kevin Wolf
2014-11-27 14:48 ` [Qemu-devel] [PATCH v2 04/13] block/nfs: Add create_opts Max Reitz
2014-11-27 14:48 ` [Qemu-devel] [PATCH v2 05/13] block: Check create_opts before image creation Max Reitz
2014-11-27 14:48 ` [Qemu-devel] [PATCH v2 06/13] qemu-img: " Max Reitz
2014-11-27 14:48 ` [Qemu-devel] [PATCH v2 07/13] qemu-img: Check create_opts before image amendment Max Reitz
2014-11-27 14:48 ` [Qemu-devel] [PATCH v2 08/13] iotests: Only kill NBD server if it runs Max Reitz
2014-11-27 14:48 ` [Qemu-devel] [PATCH v2 09/13] iotests: Add test for unsupported image creation Max Reitz
2014-11-27 14:48 ` [Qemu-devel] [PATCH v2 10/13] qcow2: Prevent numerical overflow Max Reitz
2014-11-27 14:48 ` [Qemu-devel] [PATCH v2 11/13] qcow2: Flushing the caches in qcow2_close may fail Max Reitz
2014-11-27 14:48 ` [Qemu-devel] [PATCH v2 12/13] qcow2: Respect bdrv_truncate() error Max Reitz
2014-11-27 14:48 ` [Qemu-devel] [PATCH v2 13/13] block/raw-posix: Fix ret in raw_open_common() Max Reitz
2014-12-02 11:39 ` [Qemu-devel] [PATCH v2 00/13] block: Various Coverity-spotted fixes Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417099720-16428-4-git-send-email-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).