Re: [Qemu-devel] [PATCH] hmp: fix regression of HMP device_del auto-completion

[Marcel Apfelbaum <marcel.a@redhat.com>]

On Thu, 2014-11-27 at 14:13 +0000, Peter Maydell wrote:
> On 27 November 2014 at 11:41, Marcel Apfelbaum <marcel.a@redhat.com> wrote:
> > I was talking about something different:
> > A hot-pluggable device that was not hot-plugged is assumed to be hot-unpluggable.
> > This is not true for pci-2-pci device.
> >
> > But this is another issue and can wait for 2.3.
> > So you patch was *almost* correct for looking hotpluggable devices,
> > the only problem we have is with pci-2-pci bridge (, and maybe with others that I don't know).
> 
> So, to be clear, the effect of this is just that our autocompletion
> will suggest a completion to the command which will fail if actually
> executed, right? That doesn't sound very serious, so I would be happy
> to postpone it to 2.3.
Correct. But only if this patch is applied, before this patch is a QEMU
crash.

Please pull it to solve the crash and we will deal with the other issues on 2.3

Thanks,
Marcel
> 
> -- PMM