From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XvlHl-0005mY-U6 for qemu-devel@nongnu.org; Tue, 02 Dec 2014 06:06:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XvlHf-0003lw-PJ for qemu-devel@nongnu.org; Tue, 02 Dec 2014 06:06:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41549) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XvlHf-0003lq-7b for qemu-devel@nongnu.org; Tue, 02 Dec 2014 06:06:19 -0500 From: Paolo Bonzini Date: Tue, 2 Dec 2014 12:05:49 +0100 Message-Id: <1417518350-6167-7-git-send-email-pbonzini@redhat.com> In-Reply-To: <1417518350-6167-1-git-send-email-pbonzini@redhat.com> References: <1417518350-6167-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH v2 6/7] coroutine: drop qemu_coroutine_adjust_pool_size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, ming.lei@canonical.com, pl@kamp.de, stefanha@redhat.com This is not needed anymore. The new TLS-based algorithm is adaptive. Signed-off-by: Paolo Bonzini --- block/block-backend.c | 4 ---- include/block/coroutine.h | 10 ---------- qemu-coroutine.c | 4 ---- 3 files changed, 18 deletions(-) diff --git a/block/block-backend.c b/block/block-backend.c index d0692b1..abf0cd1 100644 --- a/block/block-backend.c +++ b/block/block-backend.c @@ -260,9 +260,6 @@ int blk_attach_dev(BlockBackend *blk, void *dev) blk_ref(blk); blk->dev = dev; bdrv_iostatus_reset(blk->bs); - - /* We're expecting I/O from the device so bump up coroutine pool size */ - qemu_coroutine_adjust_pool_size(COROUTINE_POOL_RESERVATION); return 0; } @@ -290,7 +287,6 @@ void blk_detach_dev(BlockBackend *blk, void *dev) blk->dev_ops = NULL; blk->dev_opaque = NULL; bdrv_set_guest_block_size(blk->bs, 512); - qemu_coroutine_adjust_pool_size(-COROUTINE_POOL_RESERVATION); blk_unref(blk); } diff --git a/include/block/coroutine.h b/include/block/coroutine.h index 793df0e..20c027a 100644 --- a/include/block/coroutine.h +++ b/include/block/coroutine.h @@ -216,14 +216,4 @@ void coroutine_fn co_aio_sleep_ns(AioContext *ctx, QEMUClockType type, */ void coroutine_fn yield_until_fd_readable(int fd); -/** - * Add or subtract from the coroutine pool size - * - * The coroutine implementation keeps a pool of coroutines to be reused by - * qemu_coroutine_create(). This makes coroutine creation cheap. Heavy - * coroutine users should call this to reserve pool space. Call it again with - * a negative number to release pool space. - */ -void qemu_coroutine_adjust_pool_size(int n); - #endif /* QEMU_COROUTINE_H */ diff --git a/qemu-coroutine.c b/qemu-coroutine.c index aee1017..ca40f4f 100644 --- a/qemu-coroutine.c +++ b/qemu-coroutine.c @@ -144,7 +144,3 @@ void coroutine_fn qemu_coroutine_yield(void) self->caller = NULL; coroutine_swap(self, to); } - -void qemu_coroutine_adjust_pool_size(int n) -{ -} -- 2.1.0