From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH v4 01/26] qcow2: Add two new fields to BDRVQcowState
Date: Wed, 3 Dec 2014 14:37:21 +0100 [thread overview]
Message-ID: <1417613866-25890-2-git-send-email-mreitz@redhat.com> (raw)
In-Reply-To: <1417613866-25890-1-git-send-email-mreitz@redhat.com>
Add two new fields regarding refcount information (the bit width of
every entry and the maximum refcount value) to the BDRVQcowState.
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
block/qcow2-refcount.c | 2 +-
block/qcow2.c | 3 +++
block/qcow2.h | 2 ++
3 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 9afdb40..6016211 100644
--- a/block/qcow2-refcount.c
+++ b/block/qcow2-refcount.c
@@ -584,7 +584,7 @@ static int QEMU_WARN_UNUSED_RESULT update_refcount(BlockDriverState *bs,
refcount = be16_to_cpu(refcount_block[block_index]);
refcount += addend;
- if (refcount < 0 || refcount > 0xffff) {
+ if (refcount < 0 || refcount > s->refcount_max) {
ret = -EINVAL;
goto fail;
}
diff --git a/block/qcow2.c b/block/qcow2.c
index 8b9ffc4..5ed982b 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -684,6 +684,9 @@ static int qcow2_open(BlockDriverState *bs, QDict *options, int flags,
goto fail;
}
s->refcount_order = header.refcount_order;
+ s->refcount_bits = 1 << s->refcount_order;
+ s->refcount_max = UINT64_C(1) << (s->refcount_bits - 1);
+ s->refcount_max += s->refcount_max - 1;
if (header.crypt_method > QCOW_CRYPT_AES) {
error_setg(errp, "Unsupported encryption method: %" PRIu32,
diff --git a/block/qcow2.h b/block/qcow2.h
index 6e39a1b..4d8c902 100644
--- a/block/qcow2.h
+++ b/block/qcow2.h
@@ -258,6 +258,8 @@ typedef struct BDRVQcowState {
int qcow_version;
bool use_lazy_refcounts;
int refcount_order;
+ int refcount_bits;
+ uint64_t refcount_max;
bool discard_passthrough[QCOW2_DISCARD_MAX];
--
1.9.3
next prev parent reply other threads:[~2014-12-03 13:38 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 13:37 [Qemu-devel] [PATCH v4 00/26] qcow2: Support refcount orders != 4 Max Reitz
2014-12-03 13:37 ` Max Reitz [this message]
2014-12-03 14:51 ` [Qemu-devel] [PATCH v4 01/26] qcow2: Add two new fields to BDRVQcowState Eric Blake
2014-12-10 15:08 ` Stefan Hajnoczi
2014-12-03 13:37 ` [Qemu-devel] [PATCH v4 02/26] qcow2: Add refcount_bits to format-specific info Max Reitz
2014-12-03 15:09 ` Eric Blake
2014-12-10 15:14 ` Stefan Hajnoczi
2014-12-03 13:37 ` [Qemu-devel] [PATCH v4 03/26] qcow2: Do not return new value after refcount update Max Reitz
2014-12-03 15:13 ` Eric Blake
2014-12-10 15:15 ` Stefan Hajnoczi
2014-12-03 13:37 ` [Qemu-devel] [PATCH v4 04/26] qcow2: Only return status from qcow2_get_refcount Max Reitz
2014-12-03 15:37 ` Eric Blake
2014-12-10 15:32 ` Stefan Hajnoczi
2014-12-03 13:37 ` [Qemu-devel] [PATCH v4 05/26] qcow2: Use unsigned addend for update_refcount() Max Reitz
2014-12-03 15:55 ` Eric Blake
2014-12-11 10:58 ` Stefan Hajnoczi
2014-12-11 11:03 ` Max Reitz
2014-12-12 11:07 ` Stefan Hajnoczi
2014-12-03 13:37 ` [Qemu-devel] [PATCH v4 06/26] qcow2: Use 64 bits for refcount values Max Reitz
2014-12-03 16:11 ` Eric Blake
2014-12-03 16:18 ` Max Reitz
2014-12-11 11:04 ` Stefan Hajnoczi
2014-12-03 13:37 ` [Qemu-devel] [PATCH v4 07/26] qcow2: Respect error in qcow2_alloc_bytes() Max Reitz
2014-12-03 17:12 ` Eric Blake
2014-12-11 11:10 ` Stefan Hajnoczi
2014-12-03 13:37 ` [Qemu-devel] [PATCH v4 08/26] qcow2: Refcount overflow and qcow2_alloc_bytes() Max Reitz
2014-12-03 17:41 ` Eric Blake
2014-12-11 11:12 ` Stefan Hajnoczi
2014-12-03 13:37 ` [Qemu-devel] [PATCH v4 09/26] qcow2: Helper for refcount array reallocation Max Reitz
2014-12-03 18:00 ` Eric Blake
2014-12-11 11:26 ` Stefan Hajnoczi
2014-12-03 13:37 ` [Qemu-devel] [PATCH v4 10/26] qcow2: Helper function for refcount modification Max Reitz
2014-12-03 18:48 ` Eric Blake
2014-12-11 13:36 ` Stefan Hajnoczi
2014-12-03 13:37 ` [Qemu-devel] [PATCH v4 11/26] qcow2: More helpers " Max Reitz
2014-12-03 19:17 ` Eric Blake
2014-12-11 13:40 ` Stefan Hajnoczi
2014-12-03 13:37 ` [Qemu-devel] [PATCH v4 12/26] qcow2: Open images with refcount order != 4 Max Reitz
2014-12-03 13:37 ` [Qemu-devel] [PATCH v4 13/26] qcow2: refcount_order parameter for qcow2_create2 Max Reitz
2014-12-03 19:29 ` Eric Blake
2014-12-11 13:41 ` Stefan Hajnoczi
2014-12-03 13:37 ` [Qemu-devel] [PATCH v4 14/26] qcow2: Use symbolic macros in qcow2_amend_options Max Reitz
2014-12-03 19:48 ` Eric Blake
2014-12-11 14:05 ` Stefan Hajnoczi
2014-12-03 13:37 ` [Qemu-devel] [PATCH v4 15/26] iotests: Prepare for refcount_bits option Max Reitz
2014-12-03 22:05 ` Eric Blake
2014-12-11 14:26 ` Stefan Hajnoczi
2014-12-03 13:37 ` [Qemu-devel] [PATCH v4 16/26] qcow2: Allow creation with refcount order != 4 Max Reitz
2014-12-03 23:02 ` Eric Blake
2014-12-11 14:41 ` Stefan Hajnoczi
2014-12-03 13:37 ` [Qemu-devel] [PATCH v4 17/26] progress: Allow regressing progress Max Reitz
2014-12-03 23:03 ` Eric Blake
2014-12-11 14:41 ` Stefan Hajnoczi
2014-12-03 13:37 ` [Qemu-devel] [PATCH v4 18/26] block: Add opaque value to the amend CB Max Reitz
2014-12-11 14:42 ` Stefan Hajnoczi
2014-12-03 13:37 ` [Qemu-devel] [PATCH v4 19/26] qcow2: Use error_report() in qcow2_amend_options() Max Reitz
2014-12-03 13:37 ` [Qemu-devel] [PATCH v4 20/26] qcow2: Use abort() instead of assert(false) Max Reitz
2014-12-03 13:37 ` [Qemu-devel] [PATCH v4 21/26] qcow2: Split upgrade/downgrade paths for amend Max Reitz
2014-12-03 13:37 ` [Qemu-devel] [PATCH v4 22/26] qcow2: Use intermediate helper CB " Max Reitz
2014-12-11 14:44 ` Stefan Hajnoczi
2014-12-03 13:37 ` [Qemu-devel] [PATCH v4 23/26] qcow2: Add function for refcount order amendment Max Reitz
2014-12-03 23:30 ` Eric Blake
2014-12-11 17:08 ` Stefan Hajnoczi
2014-12-03 13:37 ` [Qemu-devel] [PATCH v4 24/26] qcow2: Invoke refcount order amendment function Max Reitz
2014-12-03 23:35 ` Eric Blake
2014-12-11 14:46 ` Stefan Hajnoczi
2014-12-03 13:37 ` [Qemu-devel] [PATCH v4 25/26] qcow2: Point to amend function in check Max Reitz
2014-12-11 14:46 ` Stefan Hajnoczi
2014-12-03 13:37 ` [Qemu-devel] [PATCH v4 26/26] iotests: Add test for different refcount widths Max Reitz
2014-12-04 0:03 ` Eric Blake
2014-12-04 9:51 ` Max Reitz
2014-12-04 19:10 ` Eric Blake
2014-12-05 9:02 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417613866-25890-2-git-send-email-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).