From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwB5F-0000SM-48 for qemu-devel@nongnu.org; Wed, 03 Dec 2014 09:39:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwB56-0001RA-2X for qemu-devel@nongnu.org; Wed, 03 Dec 2014 09:39:13 -0500 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:59034) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwB55-0001R0-Q3 for qemu-devel@nongnu.org; Wed, 03 Dec 2014 09:39:04 -0500 Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 3 Dec 2014 14:39:02 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 028B81B0805F for ; Wed, 3 Dec 2014 14:39:19 +0000 (GMT) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id sB3Ed07S58392690 for ; Wed, 3 Dec 2014 14:39:00 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id sB3EclfL001903 for ; Wed, 3 Dec 2014 07:38:56 -0700 From: Jens Freimann Date: Wed, 3 Dec 2014 15:38:28 +0100 Message-Id: <1417617511-6545-2-git-send-email-jfrei@linux.vnet.ibm.com> In-Reply-To: <1417617511-6545-1-git-send-email-jfrei@linux.vnet.ibm.com> References: <1417617511-6545-1-git-send-email-jfrei@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH for-2.3 1/4] s390x/ccw: fix oddity in machine class init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger , Alexander Graf , Cornelia Huck Cc: Jens Freimann , qemu-devel@nongnu.org From: Cornelia Huck ccw_machine_class_init() uses ',' instead of ';' while initializing the class' fields. This is almost certainly a copy/paste error and, while legal C, rather on the unusual side. Just use ';' everywhere. Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck Signed-off-by: Jens Freimann --- hw/s390x/s390-virtio-ccw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index bc4dc2a..f7b750d 100644 --- a/hw/s390x/s390-virtio-ccw.c +++ b/hw/s390x/s390-virtio-ccw.c @@ -181,7 +181,7 @@ static void ccw_machine_class_init(ObjectClass *oc, void *data) mc->no_serial = 1; mc->no_parallel = 1; mc->no_sdcard = 1; - mc->use_sclp = 1, + mc->use_sclp = 1; mc->max_cpus = 255; nc->nmi_monitor_handler = s390_nmi; } -- 1.8.5.5