From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58434) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwJLt-0008EZ-Tm for qemu-devel@nongnu.org; Wed, 03 Dec 2014 18:29:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwJLo-000880-07 for qemu-devel@nongnu.org; Wed, 03 Dec 2014 18:28:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35164) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwJLn-00087q-Pg for qemu-devel@nongnu.org; Wed, 03 Dec 2014 18:28:51 -0500 From: Fam Zheng Date: Thu, 4 Dec 2014 07:28:33 +0800 Message-Id: <1417649314-13704-6-git-send-email-famz@redhat.com> In-Reply-To: <1417649314-13704-1-git-send-email-famz@redhat.com> References: <1417649314-13704-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH v4 5/6] vmdk: Remove unnecessary initialization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Don Koch , Markus Armbruster , Stefan Hajnoczi , Max Reitz It will be assigned to the return value of vmdk_read_desc. Suggested-by: Markus Armbruster Signed-off-by: Fam Zheng Reviewed-by: Markus Armbruster Reviewed-by: Don Koch Reviewed-by: Max Reitz --- block/vmdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/vmdk.c b/block/vmdk.c index b703395..da2d323 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -914,7 +914,7 @@ exit: static int vmdk_open(BlockDriverState *bs, QDict *options, int flags, Error **errp) { - char *buf = NULL; + char *buf; int ret; BDRVVmdkState *s = bs->opaque; uint32_t magic; -- 1.9.3