From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, rth@twiddle.net
Subject: [Qemu-devel] [PATCH 1/4] x86: Drop superfluous conditionals around g_free()
Date: Thu, 4 Dec 2014 14:46:43 +0100 [thread overview]
Message-ID: <1417700806-23127-2-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1417700806-23127-1-git-send-email-armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/i386/pc_sysfw.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/i386/pc_sysfw.c b/hw/i386/pc_sysfw.c
index 75913c5..662d997 100644
--- a/hw/i386/pc_sysfw.c
+++ b/hw/i386/pc_sysfw.c
@@ -204,9 +204,7 @@ static void old_pc_system_rom_init(MemoryRegion *rom_memory, bool isapc_ram_fw)
fprintf(stderr, "qemu: could not load PC BIOS '%s'\n", bios_name);
exit(1);
}
- if (filename) {
- g_free(filename);
- }
+ g_free(filename);
/* map the last 128KB of the BIOS in ISA space */
isa_bios_size = bios_size;
--
1.9.3
next prev parent reply other threads:[~2014-12-04 13:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 13:46 [Qemu-devel] [PATCH 0/4] x86: Trivial cleanups around g_malloc() Markus Armbruster
2014-12-04 13:46 ` Markus Armbruster [this message]
2014-12-04 13:46 ` [Qemu-devel] [PATCH 2/4] x86: Fuse g_malloc(); memset() into g_malloc0() Markus Armbruster
2014-12-04 13:46 ` [Qemu-devel] [PATCH 3/4] x86: Use g_new() & friends where that makes obvious sense Markus Armbruster
2014-12-04 13:46 ` [Qemu-devel] [PATCH 4/4] x86: Drop some superfluous casts from void * Markus Armbruster
2014-12-05 15:09 ` [Qemu-devel] [PATCH 0/4] x86: Trivial cleanups around g_malloc() Eric Blake
2014-12-05 15:40 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417700806-23127-2-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).