qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Max Reitz" <mreitz@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Michael Müller" <mimu@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH v2 0/3] iotests: Fix test 039
Date: Thu,  4 Dec 2014 15:48:59 +0100	[thread overview]
Message-ID: <1417704542-18337-1-git-send-email-mreitz@redhat.com> (raw)

Test 039 used to fail because qemu-io -c abort may generate core dumps
even with ulimit -c 0 (and the output then contains "(core dumped)").
Fix this by adding a new qemu-io command "sigraise" which invokes
raise(). Using this command to raise SIGKILL for example does not result
in a core dump, but it still badly crashes qemu-io (as desired).

I am sending this series because we need all tests to work before adding
the check-block target to "make check" (which we will hopefully do
soon).


v2:
- Rewrote patch 1: Overloading "abort" may be somehow technically
  justifyable, but there is no point in grasping at straws when it is
  much easier to just introduce a new command. Therefore, in this
  version, "abort" is no longer overloaded and instead a new command,
  "sigraise", is added (I thought long and hard about that name; I
  thought "raise" to sound too unspecific, so this is what I came up
  with) [Markus]
- Patch 2: Fixed commit message (s/if it is aborted/when it is killed/)
  [Markus]
- Patch 3: %s/abort -S 9/sigraise 9/


git-backport-diff against v1:

Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/3:[down] 'qemu-io: Add sigraise command'
       ^^^^ wrong, should be:
      [0081] [FC]
002/3:[----] [--] 'iotests: Filter for "Killed" in qemu-io output'
003/3:[0006] [FC] 'iotests: Fix test 039'


Max Reitz (3):
  qemu-io: Add sigraise command
  iotests: Filter for "Killed" in qemu-io output
  iotests: Fix test 039

 qemu-io-cmds.c                   | 46 ++++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/039           | 12 ++++++-----
 tests/qemu-iotests/039.out       |  6 +++---
 tests/qemu-iotests/common.filter |  2 +-
 4 files changed, 57 insertions(+), 9 deletions(-)

-- 
1.9.3

             reply	other threads:[~2014-12-04 14:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-04 14:48 Max Reitz [this message]
2014-12-04 14:49 ` [Qemu-devel] [PATCH v2 1/3] qemu-io: Add sigraise command Max Reitz
2014-12-05  7:03   ` Fam Zheng
2014-12-05  9:52   ` Markus Armbruster
2014-12-05 10:07     ` Max Reitz
2014-12-05 12:23       ` Markus Armbruster
2014-12-05 13:04         ` Kevin Wolf
2014-12-05 13:05         ` Max Reitz
2014-12-05 13:59           ` Markus Armbruster
2014-12-05 14:12             ` Eric Blake
2014-12-04 14:49 ` [Qemu-devel] [PATCH v2 2/3] iotests: Filter for "Killed" in qemu-io output Max Reitz
2014-12-05  7:04   ` Fam Zheng
2014-12-04 14:49 ` [Qemu-devel] [PATCH v2 3/3] iotests: Fix test 039 Max Reitz
2014-12-05  7:08   ` Fam Zheng
2014-12-05  9:03     ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417704542-18337-1-git-send-email-mreitz@redhat.com \
    --to=mreitz@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mimu@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).