Re: [Qemu-devel] [PATCH 01/13] target-arm: Add vexpress class and machine types

[Marcel Apfelbaum <marcel.apfelbaum@gmail.com>]

On Fri, 2014-12-05 at 15:16 +0000, Peter Maydell wrote:
> On 3 December 2014 at 20:05, Greg Bellows <greg.bellows@linaro.org> wrote:
> > Adds base Vexpress class and machine objects and infrastructure.  This is in
> > preparation for switching to the full QEMU object model.  The base vexpress
> > infrastructure is intended to handle common vexpress details.
> >
> > Signed-off-by: Greg Bellows <greg.bellows@linaro.org>
> 
> This patch results in an incorrect extra line appearing in
> the "-M help output":
> vexpress             ARM Versatile Express
> and if you try to use it we dump core:
> 
> e104462:trusty:qemu$ ./build/x86/arm-softmmu/qemu-system-arm -M vexpress
> Segmentation fault (core dumped)
> 
> We need to either figure out a way for indicating that
> a subclass of MACHINE is actually an abstract subclass,
> or just have the a15 and a9 directly inherit from MACHINE.

We can just add ".abstract = true:  to vexpress_info that should be
enough.

Thanks,
Marcel

> 
> thanks
> -- PMM
>