From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39263)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.apfelbaum@gmail.com>) id 1XwyAM-00080h-KC
	for qemu-devel@nongnu.org; Fri, 05 Dec 2014 14:03:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel.apfelbaum@gmail.com>) id 1XwyAH-0005Ea-6K
	for qemu-devel@nongnu.org; Fri, 05 Dec 2014 14:03:46 -0500
Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:62298)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.apfelbaum@gmail.com>) id 1XwyAG-0005EU-VG
	for qemu-devel@nongnu.org; Fri, 05 Dec 2014 14:03:41 -0500
Received: by mail-wi0-f176.google.com with SMTP id ex7so2363684wid.9
	for <qemu-devel@nongnu.org>; Fri, 05 Dec 2014 11:03:39 -0800 (PST)
Message-ID: <1417806162.1456.7.camel@localhost.localdomain>
From: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Date: Fri, 05 Dec 2014 21:02:42 +0200
In-Reply-To: <CAFEAcA_rFwDLOMtyZOOD9QkRewEuOHUnxDud3LqDJsL_9P4Wfg@mail.gmail.com>
References: <1417637167-20640-1-git-send-email-greg.bellows@linaro.org>
	<1417637167-20640-2-git-send-email-greg.bellows@linaro.org>
	<CAFEAcA_rFwDLOMtyZOOD9QkRewEuOHUnxDud3LqDJsL_9P4Wfg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 01/13] target-arm: Add vexpress class and
 machine types
Reply-To: marcel.a@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Sergey Fedorov <serge.fdrv@gmail.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>, Fabian Aggeler <aggelerf@ethz.ch>, Greg Bellows <greg.bellows@linaro.org>

On Fri, 2014-12-05 at 15:16 +0000, Peter Maydell wrote:
> On 3 December 2014 at 20:05, Greg Bellows <greg.bellows@linaro.org> wrote:
> > Adds base Vexpress class and machine objects and infrastructure.  This is in
> > preparation for switching to the full QEMU object model.  The base vexpress
> > infrastructure is intended to handle common vexpress details.
> >
> > Signed-off-by: Greg Bellows <greg.bellows@linaro.org>
> 
> This patch results in an incorrect extra line appearing in
> the "-M help output":
> vexpress             ARM Versatile Express
> and if you try to use it we dump core:
> 
> e104462:trusty:qemu$ ./build/x86/arm-softmmu/qemu-system-arm -M vexpress
> Segmentation fault (core dumped)
> 
> We need to either figure out a way for indicating that
> a subclass of MACHINE is actually an abstract subclass,
> or just have the a15 and a9 directly inherit from MACHINE.

We can just add ".abstract = true:  to vexpress_info that should be
enough.

Thanks,
Marcel

> 
> thanks
> -- PMM
>