* [Qemu-devel] [PATCH] s390/pci: remove unnecessary cpu_synchronize_state
@ 2014-12-08 8:18 Frank Blaschka
2014-12-08 11:48 ` Thomas Huth
2014-12-09 13:34 ` Cornelia Huck
0 siblings, 2 replies; 3+ messages in thread
From: Frank Blaschka @ 2014-12-08 8:18 UTC (permalink / raw)
To: cornelia.huck, borntraeger, agraf; +Cc: Frank Blaschka, qemu-devel
Remove all unnecessary calls to cpu_synchronize_state
Signed-off-by: Frank Blaschka <blaschka@linux.vnet.ibm.com>
---
hw/s390x/s390-pci-inst.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c
index f503665..83ab60f 100644
--- a/hw/s390x/s390-pci-inst.c
+++ b/hw/s390x/s390-pci-inst.c
@@ -564,8 +564,6 @@ int pcistb_service_call(S390CPU *cpu, uint8_t r1, uint8_t r3, uint64_t gaddr)
uint8_t pcias;
uint8_t len;
- cpu_synchronize_state(CPU(cpu));
-
if (env->psw.mask & PSW_MASK_PSTATE) {
program_interrupt(env, PGM_PRIVILEGED, 6);
return 0;
@@ -711,8 +709,6 @@ int mpcifc_service_call(S390CPU *cpu, uint8_t r1, uint64_t fiba)
S390PCIBusDevice *pbdev;
uint64_t cc = ZPCI_PCI_LS_OK;
- cpu_synchronize_state(CPU(cpu));
-
if (env->psw.mask & PSW_MASK_PSTATE) {
program_interrupt(env, PGM_PRIVILEGED, 6);
return 0;
@@ -786,8 +782,6 @@ int stpcifc_service_call(S390CPU *cpu, uint8_t r1, uint64_t fiba)
uint32_t data;
uint64_t cc = ZPCI_PCI_LS_OK;
- cpu_synchronize_state(CPU(cpu));
-
if (env->psw.mask & PSW_MASK_PSTATE) {
program_interrupt(env, PGM_PRIVILEGED, 6);
return 0;
--
1.8.5.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] s390/pci: remove unnecessary cpu_synchronize_state
2014-12-08 8:18 [Qemu-devel] [PATCH] s390/pci: remove unnecessary cpu_synchronize_state Frank Blaschka
@ 2014-12-08 11:48 ` Thomas Huth
2014-12-09 13:34 ` Cornelia Huck
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2014-12-08 11:48 UTC (permalink / raw)
To: Frank Blaschka; +Cc: cornelia.huck, borntraeger, agraf, qemu-devel
On Mon, 8 Dec 2014 09:18:59 +0100
Frank Blaschka <blaschka@linux.vnet.ibm.com> wrote:
> Remove all unnecessary calls to cpu_synchronize_state
>
> Signed-off-by: Frank Blaschka <blaschka@linux.vnet.ibm.com>
> ---
> hw/s390x/s390-pci-inst.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c
> index f503665..83ab60f 100644
> --- a/hw/s390x/s390-pci-inst.c
> +++ b/hw/s390x/s390-pci-inst.c
> @@ -564,8 +564,6 @@ int pcistb_service_call(S390CPU *cpu, uint8_t r1, uint8_t r3, uint64_t gaddr)
> uint8_t pcias;
> uint8_t len;
>
> - cpu_synchronize_state(CPU(cpu));
> -
> if (env->psw.mask & PSW_MASK_PSTATE) {
> program_interrupt(env, PGM_PRIVILEGED, 6);
> return 0;
> @@ -711,8 +709,6 @@ int mpcifc_service_call(S390CPU *cpu, uint8_t r1, uint64_t fiba)
> S390PCIBusDevice *pbdev;
> uint64_t cc = ZPCI_PCI_LS_OK;
>
> - cpu_synchronize_state(CPU(cpu));
> -
> if (env->psw.mask & PSW_MASK_PSTATE) {
> program_interrupt(env, PGM_PRIVILEGED, 6);
> return 0;
> @@ -786,8 +782,6 @@ int stpcifc_service_call(S390CPU *cpu, uint8_t r1, uint64_t fiba)
> uint32_t data;
> uint64_t cc = ZPCI_PCI_LS_OK;
>
> - cpu_synchronize_state(CPU(cpu));
> -
> if (env->psw.mask & PSW_MASK_PSTATE) {
> program_interrupt(env, PGM_PRIVILEGED, 6);
> return 0;
Reviewed-by: Thomas Huth <thuth@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] s390/pci: remove unnecessary cpu_synchronize_state
2014-12-08 8:18 [Qemu-devel] [PATCH] s390/pci: remove unnecessary cpu_synchronize_state Frank Blaschka
2014-12-08 11:48 ` Thomas Huth
@ 2014-12-09 13:34 ` Cornelia Huck
1 sibling, 0 replies; 3+ messages in thread
From: Cornelia Huck @ 2014-12-09 13:34 UTC (permalink / raw)
To: Frank Blaschka; +Cc: borntraeger, agraf, qemu-devel
On Mon, 8 Dec 2014 09:18:59 +0100
Frank Blaschka <blaschka@linux.vnet.ibm.com> wrote:
> Remove all unnecessary calls to cpu_synchronize_state
>
> Signed-off-by: Frank Blaschka <blaschka@linux.vnet.ibm.com>
> ---
> hw/s390x/s390-pci-inst.c | 6 ------
> 1 file changed, 6 deletions(-)
Applied to s390-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-09 13:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-08 8:18 [Qemu-devel] [PATCH] s390/pci: remove unnecessary cpu_synchronize_state Frank Blaschka
2014-12-08 11:48 ` Thomas Huth
2014-12-09 13:34 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).