qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Fam Zheng" <famz@redhat.com>,
	"Michael Müller" <mimu@linux.vnet.ibm.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Max Reitz" <mreitz@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH v3 0/3] iotests: Fix test 039
Date: Mon,  8 Dec 2014 10:48:09 +0100	[thread overview]
Message-ID: <1418032092-16813-1-git-send-email-mreitz@redhat.com> (raw)

Test 039 used to fail because qemu-io -c abort may generate core dumps
even with ulimit -c 0 (and the output then contains "(core dumped)").
Fix this by adding a new qemu-io command "sigraise" which invokes
raise(). Using this command to raise SIGKILL for example does not result
in a core dump, but it still badly crashes qemu-io (as desired).

I am sending this series because we need all tests to work before adding
the check-block target to "make check" (which we will hopefully do
soon).


v3:
- Patch 1:
  - s/allows to raise/allows raising/ [Eric]
  - %s/Unix signal/signal/g [Markus]
  - Use SIGTERM instead of SIGKILL in the example, and don't hardcode
    its value [Markus]
- Patch 3:
  - Fix commit message (should have been "sigraise 9" instead of
    "abort -S 9", and now it's "sigraise $(kill -l KILL)") [Fam]
  - As hinted above, use "sigraise $(kill -l KILL)" instead of
    hardcoding the value 9 for SIGKILL [Markus]


git-backport-diff against v2:

Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/3:[0008] [FC] 'qemu-io: Add sigraise command'
002/3:[----] [--] 'iotests: Filter for "Killed" in qemu-io output'
003/3:[0012] [FC] 'iotests: Fix test 039'


Max Reitz (3):
  qemu-io: Add sigraise command
  iotests: Filter for "Killed" in qemu-io output
  iotests: Fix test 039

 qemu-io-cmds.c                   | 46 ++++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/039           | 18 +++++++++++-----
 tests/qemu-iotests/039.out       |  6 +++---
 tests/qemu-iotests/common.filter |  2 +-
 4 files changed, 63 insertions(+), 9 deletions(-)

-- 
1.9.3

             reply	other threads:[~2014-12-08  9:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-08  9:48 Max Reitz [this message]
2014-12-08  9:48 ` [Qemu-devel] [PATCH v3 1/3] qemu-io: Add sigraise command Max Reitz
2014-12-08 10:34   ` Fam Zheng
2014-12-08  9:48 ` [Qemu-devel] [PATCH v3 2/3] iotests: Filter for "Killed" in qemu-io output Max Reitz
2014-12-08  9:48 ` [Qemu-devel] [PATCH v3 3/3] iotests: Fix test 039 Max Reitz
2014-12-08 10:36   ` Fam Zheng
2014-12-12 16:35 ` [Qemu-devel] [PATCH v3 0/3] " Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418032092-16813-1-git-send-email-mreitz@redhat.com \
    --to=mreitz@redhat.com \
    --cc=armbru@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mimu@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).