* [Qemu-devel] [PATCH] vnc-enc-tight: fix Arguments in wrong order
@ 2014-11-20 9:07 arei.gonglei
2014-11-25 16:56 ` Stefan Hajnoczi
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: arei.gonglei @ 2014-11-20 9:07 UTC (permalink / raw)
To: qemu-devel; +Cc: Gonglei, Gerd Hoffmann
From: Gonglei <arei.gonglei@huawei.com>
Arguments in wrong order (SWAPPED_ARGUMENTS)
The positions of arguments in the call to
tight_fill_palette do not match the ordering of the parameters:
&fg is passed to bg
&bg is passed to fg
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
---
ui/vnc-enc-tight.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index 3d1b5cd..9a9ddf2 100644
--- a/ui/vnc-enc-tight.c
+++ b/ui/vnc-enc-tight.c
@@ -1489,7 +1489,7 @@ static int send_sub_rect(VncState *vs, int x, int y, int w, int h)
}
#endif
- colors = tight_fill_palette(vs, x, y, w * h, &fg, &bg, &palette);
+ colors = tight_fill_palette(vs, x, y, w * h, &bg, &fg, &palette);
#ifdef CONFIG_VNC_JPEG
if (allow_jpeg && vs->tight.quality != (uint8_t)-1) {
--
1.7.12.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] vnc-enc-tight: fix Arguments in wrong order
2014-11-20 9:07 [Qemu-devel] [PATCH] vnc-enc-tight: fix Arguments in wrong order arei.gonglei
@ 2014-11-25 16:56 ` Stefan Hajnoczi
2014-12-08 11:43 ` Gonglei
2014-12-08 11:50 ` Gerd Hoffmann
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2014-11-25 16:56 UTC (permalink / raw)
To: arei.gonglei; +Cc: qemu-devel, Gerd Hoffmann
[-- Attachment #1: Type: text/plain, Size: 567 bytes --]
On Thu, Nov 20, 2014 at 05:07:06PM +0800, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> Arguments in wrong order (SWAPPED_ARGUMENTS)
> The positions of arguments in the call to
> tight_fill_palette do not match the ordering of the parameters:
> &fg is passed to bg
> &bg is passed to fg
>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> ui/vnc-enc-tight.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] vnc-enc-tight: fix Arguments in wrong order
2014-11-20 9:07 [Qemu-devel] [PATCH] vnc-enc-tight: fix Arguments in wrong order arei.gonglei
2014-11-25 16:56 ` Stefan Hajnoczi
@ 2014-12-08 11:43 ` Gonglei
2014-12-08 11:50 ` Gerd Hoffmann
2 siblings, 0 replies; 4+ messages in thread
From: Gonglei @ 2014-12-08 11:43 UTC (permalink / raw)
To: Gonglei (Arei); +Cc: qemu-devel@nongnu.org, Gerd Hoffmann
On 2014/11/20 17:07, Gonglei (Arei) wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> Arguments in wrong order (SWAPPED_ARGUMENTS)
> The positions of arguments in the call to
> tight_fill_palette do not match the ordering of the parameters:
> &fg is passed to bg
> &bg is passed to fg
>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> ui/vnc-enc-tight.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
> index 3d1b5cd..9a9ddf2 100644
> --- a/ui/vnc-enc-tight.c
> +++ b/ui/vnc-enc-tight.c
> @@ -1489,7 +1489,7 @@ static int send_sub_rect(VncState *vs, int x, int y, int w, int h)
> }
> #endif
>
> - colors = tight_fill_palette(vs, x, y, w * h, &fg, &bg, &palette);
> + colors = tight_fill_palette(vs, x, y, w * h, &bg, &fg, &palette);
>
> #ifdef CONFIG_VNC_JPEG
> if (allow_jpeg && vs->tight.quality != (uint8_t)-1) {
Ping...
Regards,
-Gonglei
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] vnc-enc-tight: fix Arguments in wrong order
2014-11-20 9:07 [Qemu-devel] [PATCH] vnc-enc-tight: fix Arguments in wrong order arei.gonglei
2014-11-25 16:56 ` Stefan Hajnoczi
2014-12-08 11:43 ` Gonglei
@ 2014-12-08 11:50 ` Gerd Hoffmann
2 siblings, 0 replies; 4+ messages in thread
From: Gerd Hoffmann @ 2014-12-08 11:50 UTC (permalink / raw)
To: arei.gonglei; +Cc: qemu-devel
On Do, 2014-11-20 at 17:07 +0800, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> Arguments in wrong order (SWAPPED_ARGUMENTS)
> The positions of arguments in the call to
> tight_fill_palette do not match the ordering of the parameters:
> &fg is passed to bg
> &bg is passed to fg
Added to vnc queue.
thanks,
Gerd
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-12-08 11:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-20 9:07 [Qemu-devel] [PATCH] vnc-enc-tight: fix Arguments in wrong order arei.gonglei
2014-11-25 16:56 ` Stefan Hajnoczi
2014-12-08 11:43 ` Gonglei
2014-12-08 11:50 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).