qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: marcel.a@redhat.com, mst@redhat.com
Subject: [Qemu-devel] [PATCH 3/9] pc: acpi-build: cleanup AcpiPmInfo initialization
Date: Mon,  8 Dec 2014 16:08:02 +0000	[thread overview]
Message-ID: <1418054888-11310-4-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1418054888-11310-1-git-send-email-imammedo@redhat.com>

zero initialize AcpiPmInfo struct to reduce code bloat
a little bit.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
 hw/i386/acpi-build.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 1fb92e5..f5ec66a 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -161,6 +161,8 @@ static void acpi_get_pm_info(AcpiPmInfo *pm)
     Object *obj = NULL;
     QObject *o;
 
+    memset(pm, 0, sizeof(*pm));
+
     if (piix) {
         obj = piix;
     }
@@ -173,22 +175,16 @@ static void acpi_get_pm_info(AcpiPmInfo *pm)
     o = object_property_get_qobject(obj, ACPI_PM_PROP_S3_DISABLED, NULL);
     if (o) {
         pm->s3_disabled = qint_get_int(qobject_to_qint(o));
-    } else {
-        pm->s3_disabled = false;
     }
     qobject_decref(o);
     o = object_property_get_qobject(obj, ACPI_PM_PROP_S4_DISABLED, NULL);
     if (o) {
         pm->s4_disabled = qint_get_int(qobject_to_qint(o));
-    } else {
-        pm->s4_disabled = false;
     }
     qobject_decref(o);
     o = object_property_get_qobject(obj, ACPI_PM_PROP_S4_VAL, NULL);
     if (o) {
         pm->s4_val = qint_get_int(qobject_to_qint(o));
-    } else {
-        pm->s4_val = false;
     }
     qobject_decref(o);
 
-- 
1.8.3.1

  parent reply	other threads:[~2014-12-08 16:08 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-08 16:07 [Qemu-devel] [PATCH 0/9] pc: acpi: various fixes and cleanups Igor Mammedov
2014-12-08 16:08 ` [Qemu-devel] [PATCH 1/9] pc: acpi: fix WindowsXP BSOD when memory hotplug is enabled Igor Mammedov
2014-12-08 20:57   ` Michael S. Tsirkin
2014-12-09 10:05     ` Igor Mammedov
2014-12-09 10:33       ` Michael S. Tsirkin
2014-12-08 16:08 ` [Qemu-devel] [PATCH 2/9] pc: acpi: decribe bridge device as not hotpluggable Igor Mammedov
2014-12-08 19:13   ` Michael S. Tsirkin
2014-12-09 10:27     ` Igor Mammedov
2014-12-09 10:34       ` Michael S. Tsirkin
2014-12-09 11:45         ` Igor Mammedov
2014-12-09 12:51           ` Michael S. Tsirkin
2014-12-09 12:57             ` Igor Mammedov
2014-12-09 13:16               ` Michael S. Tsirkin
2014-12-09 13:08             ` Igor Mammedov
2014-12-08 16:08 ` Igor Mammedov [this message]
2014-12-08 21:03   ` [Qemu-devel] [PATCH 3/9] pc: acpi-build: cleanup AcpiPmInfo initialization Michael S. Tsirkin
2014-12-09 10:29     ` Igor Mammedov
2014-12-08 16:08 ` [Qemu-devel] [PATCH 4/9] acpi: build_append_nameseg(): add padding if necessary Igor Mammedov
2014-12-08 21:15   ` Michael S. Tsirkin
2014-12-09 10:32     ` Igor Mammedov
2014-12-09 10:38       ` Michael S. Tsirkin
2014-12-09 12:55         ` Igor Mammedov
2014-12-08 16:08 ` [Qemu-devel] [PATCH 5/9] acpi: move generic aml building helpers into dedictated file Igor Mammedov
2014-12-08 20:43   ` Michael S. Tsirkin
2014-12-09 10:37     ` Igor Mammedov
2014-12-08 16:08 ` [Qemu-devel] [PATCH 6/9] acpi: add build_append_namestring() helper Igor Mammedov
2014-12-08 20:21   ` Michael S. Tsirkin
2014-12-09 10:39     ` Igor Mammedov
2014-12-09 12:02       ` Michael S. Tsirkin
2014-12-09 12:59         ` Igor Mammedov
2014-12-08 16:08 ` [Qemu-devel] [PATCH 7/9] acpi: replace opencoded notify codes with named values Igor Mammedov
2014-12-08 20:54   ` Michael S. Tsirkin
2014-12-09 10:59     ` Igor Mammedov
2014-12-08 16:08 ` [Qemu-devel] [PATCH 8/9] acpi: drop min-bytes in build_package() Igor Mammedov
2014-12-08 16:08 ` [Qemu-devel] [PATCH 9/9] pc: acpi-build: replace recursive PCI bus tree generation with loop based Igor Mammedov
2014-12-08 20:43   ` Michael S. Tsirkin
2014-12-09 14:01     ` Igor Mammedov
2014-12-09 14:29       ` Michael S. Tsirkin
2014-12-11 11:09         ` [Qemu-devel] [PATCH V2 9/9] pc: acpi-build: simplify PCI bus tree generation Igor Mammedov
2014-12-08 20:43 ` [Qemu-devel] [PATCH 0/9] pc: acpi: various fixes and cleanups Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418054888-11310-4-git-send-email-imammedo@redhat.com \
    --to=imammedo@redhat.com \
    --cc=marcel.a@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).