From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40796) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xy0rJ-00026B-Mh for qemu-devel@nongnu.org; Mon, 08 Dec 2014 11:08:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xy0rD-00026f-8Y for qemu-devel@nongnu.org; Mon, 08 Dec 2014 11:08:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59420) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xy0rD-00026S-1p for qemu-devel@nongnu.org; Mon, 08 Dec 2014 11:08:19 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB8G8IHh011892 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 8 Dec 2014 11:08:18 -0500 From: Igor Mammedov Date: Mon, 8 Dec 2014 16:08:06 +0000 Message-Id: <1418054888-11310-8-git-send-email-imammedo@redhat.com> In-Reply-To: <1418054888-11310-1-git-send-email-imammedo@redhat.com> References: <1418054888-11310-1-git-send-email-imammedo@redhat.com> Subject: [Qemu-devel] [PATCH 7/9] acpi: replace opencoded notify codes with named values List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: marcel.a@redhat.com, mst@redhat.com Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 4 ++-- include/hw/acpi/acpi_gen_utils.h | 6 ++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 0f6202d..a33d130 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -840,10 +840,10 @@ static void build_pci_bus_end(PCIBus *bus, void *bus_state) build_append_namestring(method, "BNUM"); build_append_namestring(method, "DVNT"); build_append_namestring(method, "PCIU"); - build_append_int(method, 1); /* Device Check */ + build_append_int(method, ACPI_DEV_CHK); build_append_namestring(method, "DVNT"); build_append_namestring(method, "PCID"); - build_append_int(method, 3); /* Eject Request */ + build_append_int(method, ACPI_DEV_EJ); } /* Notify about child bus events in any case */ diff --git a/include/hw/acpi/acpi_gen_utils.h b/include/hw/acpi/acpi_gen_utils.h index fd50625..ce76dc1 100644 --- a/include/hw/acpi/acpi_gen_utils.h +++ b/include/hw/acpi/acpi_gen_utils.h @@ -5,6 +5,12 @@ #include #include "qemu/compiler.h" +/* ACPI 5.0: table "Device Object Notification Values" */ +enum { + ACPI_DEV_CHK = 1, + ACPI_DEV_EJ = 3, +}; + GArray *build_alloc_array(void); void build_free_array(GArray *array); void build_prepend_byte(GArray *array, uint8_t val); -- 1.8.3.1