From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58584) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyddP-00048f-Ei for qemu-devel@nongnu.org; Wed, 10 Dec 2014 04:32:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XyddK-0005n7-Kc for qemu-devel@nongnu.org; Wed, 10 Dec 2014 04:32:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43720) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyddK-0005n2-Cb for qemu-devel@nongnu.org; Wed, 10 Dec 2014 04:32:34 -0500 From: Gerd Hoffmann Date: Wed, 10 Dec 2014 10:32:19 +0100 Message-Id: <1418203940-5421-2-git-send-email-kraxel@redhat.com> In-Reply-To: <1418203940-5421-1-git-send-email-kraxel@redhat.com> References: <1418203940-5421-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PULL 1/2] vnc-enc-tight: fix Arguments in wrong order List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gonglei , Gerd Hoffmann , Anthony Liguori From: Gonglei Arguments in wrong order (SWAPPED_ARGUMENTS) The positions of arguments in the call to tight_fill_palette do not match the ordering of the parameters: &fg is passed to bg &bg is passed to fg Cc: Gerd Hoffmann Signed-off-by: Gonglei Signed-off-by: Gerd Hoffmann --- ui/vnc-enc-tight.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c index 3d1b5cd..9a9ddf2 100644 --- a/ui/vnc-enc-tight.c +++ b/ui/vnc-enc-tight.c @@ -1489,7 +1489,7 @@ static int send_sub_rect(VncState *vs, int x, int y, int w, int h) } #endif - colors = tight_fill_palette(vs, x, y, w * h, &fg, &bg, &palette); + colors = tight_fill_palette(vs, x, y, w * h, &bg, &fg, &palette); #ifdef CONFIG_VNC_JPEG if (allow_jpeg && vs->tight.quality != (uint8_t)-1) { -- 1.8.3.1