From: Jun Li <junmuzi@gmail.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, juli@redhat.com,
stefanha@redhat.com, josh.durgin@inktank.com,
Jun Li <junmuzi@gmail.com>
Subject: [Qemu-devel] [PATCH] rbd: print a clear error message when write beyond EOF
Date: Wed, 10 Dec 2014 23:47:37 +0800 [thread overview]
Message-ID: <1418226457-22239-1-git-send-email-junmuzi@gmail.com> (raw)
Currently, as rbd driver do not support dynamic growth when write beyond EOF,
so just print a clear error message.
Signed-off-by: Jun Li <junmuzi@gmail.com>
---
block/rbd.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/block/rbd.c b/block/rbd.c
index 5b5a64a..65b01f0 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -693,6 +693,20 @@ static BlockAIOCB *qemu_rbd_aio_writev(BlockDriverState *bs,
BlockCompletionFunc *cb,
void *opaque)
{
+ BDRVRBDState *s = bs->opaque;
+ uint64_t total_size;
+ int64_t off, size;
+
+ off = sector_num * BDRV_SECTOR_SIZE;
+ size = nb_sectors * BDRV_SECTOR_SIZE;
+ rbd_get_size(s->image, &total_size);
+
+ if (off + size > total_size) {
+ fprintf(stdout, "Image formats that grow on demand"
+ "are not supported on rbd.\n");
+ return NULL;
+ }
+
return rbd_start_aio(bs, sector_num, qiov, nb_sectors, cb, opaque,
RBD_AIO_WRITE);
}
--
1.9.3
next reply other threads:[~2014-12-10 15:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 15:47 Jun Li [this message]
2014-12-10 21:48 ` [Qemu-devel] [PATCH] rbd: print a clear error message when write beyond EOF Josh Durgin
2014-12-11 3:20 ` Jun Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418226457-22239-1-git-send-email-junmuzi@gmail.com \
--to=junmuzi@gmail.com \
--cc=famz@redhat.com \
--cc=josh.durgin@inktank.com \
--cc=juli@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).