From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32975) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyxBl-0004Cd-J3 for qemu-devel@nongnu.org; Thu, 11 Dec 2014 01:25:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XyxBc-00043P-IL for qemu-devel@nongnu.org; Thu, 11 Dec 2014 01:25:25 -0500 Received: from mail-pa0-x236.google.com ([2607:f8b0:400e:c03::236]:48788) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyxBc-00043G-Ax for qemu-devel@nongnu.org; Thu, 11 Dec 2014 01:25:16 -0500 Received: by mail-pa0-f54.google.com with SMTP id fb1so4402574pad.41 for ; Wed, 10 Dec 2014 22:25:15 -0800 (PST) From: Jun Li Date: Thu, 11 Dec 2014 14:25:07 +0800 Message-Id: <1418279107-10339-1-git-send-email-junmuzi@gmail.com> Subject: [Qemu-devel] [PATCH v2] rbd: print a clear error message when write beyond EOF List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, juli@redhat.com, stefanha@redhat.com, josh.durgin@inktank.com, Jun Li Currently, as rbd driver do not support dynamic growth when write beyond EOF, so just print a clear error message. Signed-off-by: Jun Li --- v2: Just use rbd_aio_write to realize error detection. --- block/rbd.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/block/rbd.c b/block/rbd.c index 5b5a64a..710ee3e 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -661,6 +661,10 @@ static BlockAIOCB *rbd_start_aio(BlockDriverState *bs, } if (r < 0) { + if (r == -EINVAL && cmd == RBD_AIO_WRITE) { + fprintf(stderr, "Image formats that grow on demand " + "are not supported on rbd.\n"); + } goto failed_completion; } -- 1.9.3