From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36063)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Xyzii-0001b2-Oz
	for qemu-devel@nongnu.org; Thu, 11 Dec 2014 04:07:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Xyzic-0008ON-KH
	for qemu-devel@nongnu.org; Thu, 11 Dec 2014 04:07:36 -0500
Received: from mx1.redhat.com ([209.132.183.28]:55262)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Xyzic-0008OF-BT
	for qemu-devel@nongnu.org; Thu, 11 Dec 2014 04:07:30 -0500
Message-ID: <1418288844.1664.10.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Thu, 11 Dec 2014 10:07:24 +0100
In-Reply-To: <54887A35.3070801@redhat.com>
References: <1418204253-5869-1-git-send-email-kraxel@redhat.com>
	<1418204253-5869-10-git-send-email-kraxel@redhat.com>
	<54887A35.3070801@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>, Luiz Capitulino <lcapitulino@redhat.com>

  Hi,

> > +# @auth: The current authentication type used by the server
> > +#        'none' if no authentication is being used
> > +#        'vnc' if VNC authentication is being used
> > +#        'vencrypt+plain' if VEncrypt is used with plain text authentication
> > +#        'vencrypt+tls+none' if VEncrypt is used with TLS and no authentication
> > +#        'vencrypt+tls+vnc' if VEncrypt is used with TLS and VNC authentication
> > +#        'vencrypt+tls+plain' if VEncrypt is used with TLS and plain text auth
> > +#        'vencrypt+x509+none' if VEncrypt is used with x509 and no auth
> > +#        'vencrypt+x509+vnc' if VEncrypt is used with x509 and VNC auth
> > +#        'vencrypt+x509+plain' if VEncrypt is used with x509 and plain text auth
> > +#        'vencrypt+tls+sasl' if VEncrypt is used with TLS and SASL auth
> > +#        'vencrypt+x509+sasl' if VEncrypt is used with x509 and SASL auth
> 
> This feels like an open-coded string that should instead be an array of
> enum values.

This is just copyed over from the old query-vnc command.

We can try to do that in a cleaner way for query-vnc2.  That implies
libvirt needs to be able to handle both formats though.

Adding danbp who did most vnc auth stuff for comments.

>   That is,
> 
> { 'enum': 'VncAuth', 'data', [ 'none', 'vnc', 'vencrypt', 'plain',
> 'tls', 'x509' ] }

> ... 'auth': ['VcnAuth']

Looked at the source, figured the list grew meanwhile.

Do we need 'none' here?  When we have a list anyway we can have an empty
list instead.

cheers,
  Gerd