From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36461) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyzkG-0002ku-FR for qemu-devel@nongnu.org; Thu, 11 Dec 2014 04:09:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XyzkA-0000d5-8P for qemu-devel@nongnu.org; Thu, 11 Dec 2014 04:09:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55432) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyzkA-0000cr-0K for qemu-devel@nongnu.org; Thu, 11 Dec 2014 04:09:06 -0500 Message-ID: <1418288939.1664.12.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Thu, 11 Dec 2014 10:08:59 +0100 In-Reply-To: <54887ABB.6090605@redhat.com> References: <1418204253-5869-1-git-send-email-kraxel@redhat.com> <1418204253-5869-11-git-send-email-kraxel@redhat.com> <54887ABB.6090605@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 10/10] monitor: add vnc websockets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Markus Armbruster , qemu-devel@nongnu.org, Anthony Liguori , Luiz Capitulino > > +# @websocket: #optional true in case the socket is a websocket (since 2.2). > > s/2.2/2.3/ Fixed. > Is it optional because you omit it when false? Why not just always > output the bool, so that clients know they are talking to a new-enough > qemu that knows about websockets (and this is explicitly not one), vs. > having to guess that the omission of the bool implies that it is not > rather than being an older qemu. Makes sense, dropped optional. Also simplifies the code a bit ;) cheers, Gerd