qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>, Anthony Liguori <aliguori@amazon.com>
Subject: [Qemu-devel] [PATCH 09/10] sdl2: factor out sdl2_poll_events
Date: Thu, 11 Dec 2014 11:49:32 +0100	[thread overview]
Message-ID: <1418294973-21790-10-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1418294973-21790-1-git-send-email-kraxel@redhat.com>

Create a new function to poll and handle sdl2 events,
which is then just called from the refresh timer.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 include/ui/sdl2.h |  1 +
 ui/sdl2.c         | 23 +++++++++++++----------
 2 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/include/ui/sdl2.h b/include/ui/sdl2.h
index 048340f..27b3132 100644
--- a/include/ui/sdl2.h
+++ b/include/ui/sdl2.h
@@ -13,6 +13,7 @@ struct sdl2_console {
 void sdl2_window_create(struct sdl2_console *scon);
 void sdl2_window_destroy(struct sdl2_console *scon);
 void sdl2_window_resize(struct sdl2_console *scon);
+void sdl2_poll_events(struct sdl2_console *scon);
 
 void sdl2_reset_keys(struct sdl2_console *scon);
 void sdl2_process_key(struct sdl2_console *scon,
diff --git a/ui/sdl2.c b/ui/sdl2.c
index 1798902..8d10e0e 100644
--- a/ui/sdl2.c
+++ b/ui/sdl2.c
@@ -507,10 +507,8 @@ static void handle_mousewheel(SDL_Event *ev)
     qemu_input_event_sync();
 }
 
-static void handle_windowevent(DisplayChangeListener *dcl, SDL_Event *ev)
+static void handle_windowevent(struct sdl2_console *scon, SDL_Event *ev)
 {
-    struct sdl2_console *scon = get_scon_from_window(ev->key.windowID);
-
     switch (ev->window.event) {
     case SDL_WINDOWEVENT_RESIZED:
         {
@@ -537,10 +535,10 @@ static void handle_windowevent(DisplayChangeListener *dcl, SDL_Event *ev)
         }
         break;
     case SDL_WINDOWEVENT_RESTORED:
-        update_displaychangelistener(dcl, GUI_REFRESH_INTERVAL_DEFAULT);
+        update_displaychangelistener(&scon->dcl, GUI_REFRESH_INTERVAL_DEFAULT);
         break;
     case SDL_WINDOWEVENT_MINIMIZED:
-        update_displaychangelistener(dcl, 500);
+        update_displaychangelistener(&scon->dcl, 500);
         break;
     case SDL_WINDOWEVENT_CLOSE:
         if (!no_quit) {
@@ -551,9 +549,8 @@ static void handle_windowevent(DisplayChangeListener *dcl, SDL_Event *ev)
     }
 }
 
-static void sdl_refresh(DisplayChangeListener *dcl)
+void sdl2_poll_events(struct sdl2_console *scon)
 {
-    struct sdl2_console *scon = container_of(dcl, struct sdl2_console, dcl);
     SDL_Event ev1, *ev = &ev1;
 
     if (scon->last_vm_running != runstate_is_running()) {
@@ -561,8 +558,6 @@ static void sdl_refresh(DisplayChangeListener *dcl)
         sdl_update_caption(scon);
     }
 
-    graphic_hw_update(dcl->con);
-
     while (SDL_PollEvent(ev)) {
         switch (ev->type) {
         case SDL_KEYDOWN:
@@ -591,7 +586,7 @@ static void sdl_refresh(DisplayChangeListener *dcl)
             handle_mousewheel(ev);
             break;
         case SDL_WINDOWEVENT:
-            handle_windowevent(dcl, ev);
+            handle_windowevent(scon, ev);
             break;
         default:
             break;
@@ -599,6 +594,14 @@ static void sdl_refresh(DisplayChangeListener *dcl)
     }
 }
 
+static void sdl_refresh(DisplayChangeListener *dcl)
+{
+    struct sdl2_console *scon = container_of(dcl, struct sdl2_console, dcl);
+
+    graphic_hw_update(dcl->con);
+    sdl2_poll_events(scon);
+}
+
 static void sdl_mouse_warp(DisplayChangeListener *dcl,
                            int x, int y, int on)
 {
-- 
1.8.3.1

  parent reply	other threads:[~2014-12-11 10:49 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-11 10:49 [Qemu-devel] [PATCH 00/10] sdl2: fixes, cleanups and opengl preparation Gerd Hoffmann
2014-12-11 10:49 ` [Qemu-devel] [PATCH 01/10] sdl: move version logic from source code to makefile Gerd Hoffmann
2014-12-11 14:05   ` Max Reitz
2014-12-11 10:49 ` [Qemu-devel] [PATCH 02/10] sdl2: rename sdl2_state to sdl2_console, move to header file Gerd Hoffmann
2014-12-11 13:45   ` Max Reitz
2014-12-12  9:03     ` Gerd Hoffmann
2014-12-11 10:49 ` [Qemu-devel] [PATCH 03/10] sdl2: move keyboard input code to new sdl2-input.c Gerd Hoffmann
2014-12-11 14:00   ` Max Reitz
2014-12-12 10:38     ` Gerd Hoffmann
2014-12-11 10:49 ` [Qemu-devel] [PATCH 04/10] sdl2: turn on keyboard grabs Gerd Hoffmann
2014-12-11 14:05   ` Max Reitz
2014-12-11 10:49 ` [Qemu-devel] [PATCH 05/10] sdl2: move sdl_update to new sdl2-2d.c Gerd Hoffmann
2014-12-11 14:14   ` Max Reitz
2014-12-11 10:49 ` [Qemu-devel] [PATCH 06/10] sdl2: overhaul window size handling Gerd Hoffmann
2014-12-11 14:42   ` Max Reitz
2014-12-11 15:06   ` Max Reitz
2014-12-12 10:43     ` Gerd Hoffmann
2014-12-11 10:49 ` [Qemu-devel] [PATCH 07/10] sdl2: move sdl_switch to sdl2-2d.c Gerd Hoffmann
2014-12-11 15:00   ` Max Reitz
2014-12-11 10:49 ` [Qemu-devel] [PATCH 08/10] sdl2: add+use sdl2_2d_redraw function Gerd Hoffmann
2014-12-11 15:07   ` Max Reitz
2014-12-11 10:49 ` Gerd Hoffmann [this message]
2014-12-11 15:17   ` [Qemu-devel] [PATCH 09/10] sdl2: factor out sdl2_poll_events Max Reitz
2014-12-11 10:49 ` [Qemu-devel] [PATCH 10/10] sdl2: move sdl2_2d_refresh to sdl2-2d.c Gerd Hoffmann
2014-12-11 15:19   ` Max Reitz
2014-12-12 10:45     ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418294973-21790-10-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).