qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>,
	qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>,
	Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command
Date: Thu, 11 Dec 2014 12:33:35 +0100	[thread overview]
Message-ID: <1418297615.1664.36.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <20141211094046.GA23831@redhat.com>

  Hi,

> That's not a correct interpretation of the auth values - tls and x509 are
> not separate auth codes. VNC has one set of primary auth codes really
> 
>   none, vnc, vencrypt

Well, the source code also has (see vnc_auth_name in ui/vnc.c):

ra2, ra2ne, tight, ultra, tls, sasl

> If using the vencrypt option there are a number of sub-auth codes
> 
>    tls-none, tls-vnc, tls-plain, tls-sasl x509-none, x509-vnc, x509-plain, x509-sasl

So better add a 'vencrypt-subauth' enum with this list?

cheers,
  Gerd

  reply	other threads:[~2014-12-11 11:33 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-10  9:37 [Qemu-devel] [PATCH v2 00/10] vnc: add support for multiple vnc displays Gerd Hoffmann
2014-12-10  9:37 ` [Qemu-devel] [PATCH v2 01/10] vnc: remove vnc_display global Gerd Hoffmann
2014-12-11  1:58   ` Gonglei
2014-12-10  9:37 ` [Qemu-devel] [PATCH v2 02/10] vnc: remove unused DisplayState parameter, add id instead Gerd Hoffmann
2014-12-11  1:59   ` Gonglei
2014-12-10  9:37 ` [Qemu-devel] [PATCH v2 03/10] vnc: add display id to acl names Gerd Hoffmann
2014-12-11  2:09   ` Gonglei
2014-12-10  9:37 ` [Qemu-devel] [PATCH v2 04/10] vnc: switch to QemuOpts, allow multiple servers Gerd Hoffmann
2014-12-11  2:59   ` Gonglei
2014-12-11  8:48     ` Gerd Hoffmann
2014-12-10  9:37 ` [Qemu-devel] [PATCH v2 05/10] vnc: allow binding servers to qemu consoles Gerd Hoffmann
2014-12-10  9:37 ` [Qemu-devel] [PATCH v2 06/10] vnc: update docs/multiseat.txt Gerd Hoffmann
2014-12-10  9:37 ` [Qemu-devel] [PATCH v2 07/10] vnc: track & limit connections Gerd Hoffmann
2014-12-10  9:37 ` [Qemu-devel] [PATCH v2 08/10] vnc: factor out qmp_query_client_list Gerd Hoffmann
2014-12-10  9:37 ` [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command Gerd Hoffmann
2014-12-10 16:52   ` Eric Blake
2014-12-11  9:07     ` Gerd Hoffmann
2014-12-11  9:43       ` Daniel P. Berrange
2014-12-11  9:40     ` Daniel P. Berrange
2014-12-11 11:33       ` Gerd Hoffmann [this message]
2014-12-11 11:47         ` Daniel P. Berrange
2014-12-15  9:16           ` Gerd Hoffmann
2014-12-15  9:26             ` Daniel P. Berrange
2014-12-15 16:22             ` Eric Blake
2014-12-16 10:18               ` Gerd Hoffmann
2014-12-16 16:13                 ` Eric Blake
2014-12-10  9:37 ` [Qemu-devel] [PATCH v2 10/10] monitor: add vnc websockets Gerd Hoffmann
2014-12-10 16:54   ` Eric Blake
2014-12-11  9:08     ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418297615.1664.36.camel@nilsson.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).