From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33852) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xz20C-0003cm-8D for qemu-devel@nongnu.org; Thu, 11 Dec 2014 06:33:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xz206-0006JC-1g for qemu-devel@nongnu.org; Thu, 11 Dec 2014 06:33:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59697) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xz205-0006Ix-Q0 for qemu-devel@nongnu.org; Thu, 11 Dec 2014 06:33:41 -0500 Message-ID: <1418297615.1664.36.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Thu, 11 Dec 2014 12:33:35 +0100 In-Reply-To: <20141211094046.GA23831@redhat.com> References: <1418204253-5869-1-git-send-email-kraxel@redhat.com> <1418204253-5869-10-git-send-email-kraxel@redhat.com> <54887A35.3070801@redhat.com> <20141211094046.GA23831@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Luiz Capitulino , qemu-devel@nongnu.org, Anthony Liguori , Markus Armbruster Hi, > That's not a correct interpretation of the auth values - tls and x509 are > not separate auth codes. VNC has one set of primary auth codes really > > none, vnc, vencrypt Well, the source code also has (see vnc_auth_name in ui/vnc.c): ra2, ra2ne, tight, ultra, tls, sasl > If using the vencrypt option there are a number of sub-auth codes > > tls-none, tls-vnc, tls-plain, tls-sasl x509-none, x509-vnc, x509-plain, x509-sasl So better add a 'vencrypt-subauth' enum with this list? cheers, Gerd