qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RfC PATCH 0/3] sdl2: add opengl rendering support
Date: Thu, 11 Dec 2014 16:29:00 +0100	[thread overview]
Message-ID: <1418311740.1664.48.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <20141211123230.GF23831@redhat.com>

  Hi,

> > Second for the long term there will be 3d support in a number of UIs:
> > I expect sdl2, gtk, egl (using render nodes, for headless) and spice.
> > Having a global switch for them all looks easier.
> 
> In libvirt we model the ability to turn on 3d support for guests against
> the video device, rather than the backend device, since it is a guest
> visible feature. So should we do this against the virtual virtio-vga
> device and have the backends just tie their behaviour to that ?

There will be a switch for the video device anyway, probably something
along the lines of '-device virtio-vga,opengl={on,off,auto}'.

'off' behavior is obvious ;)
'on' must fail in case the ui has no 3d support, but the video doesn't
know that at initialization time.
'auto' should enable 3d in case ui supports it, but again we have the
problem here is that the device doesn't know at init time.

With a global switch we can tell the video device 'we want run
with/without 3d support' and have it initialize accordingly.  Likewise
ui initialization can check the flag and figure whenever it should take
the 3d or non-3d code paths.  Finally after ui init is done we can look
whenever we actually have 3d support when it was requested and error out
in case we havn't.

Also note that opengl in the ui is useful even in case the video device
doesn't support opengl: scaling the display with opengl is faster than
doing it in software, so letting virtio-vga flip the global 3d switch
isn't a good idea too.

cheers,
  Gerd

  reply	other threads:[~2014-12-11 15:29 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-11 11:05 [Qemu-devel] [RfC PATCH 0/3] sdl2: add opengl rendering support Gerd Hoffmann
2014-12-11 11:05 ` [Qemu-devel] [RfC PATCH 1/3] configure: opengl overhaul Gerd Hoffmann
2014-12-15 16:46   ` Michael Walle
2014-12-16  9:37     ` Gerd Hoffmann
2014-12-11 11:05 ` [Qemu-devel] [RfC PATCH 2/3] sdl2: add support for display rendering using opengl Gerd Hoffmann
2014-12-11 15:57   ` Max Reitz
2014-12-12 11:04     ` Gerd Hoffmann
2014-12-12 13:34       ` Max Reitz
2015-01-12 12:46         ` Gerd Hoffmann
2015-01-15 11:15           ` Gerd Hoffmann
2015-01-15 12:17             ` Paolo Bonzini
2015-01-15 12:23               ` Peter Maydell
2015-01-15 14:30                 ` Gerd Hoffmann
2015-01-15 16:49           ` Max Reitz
2014-12-11 11:05 ` [Qemu-devel] [RfC PATCH 3/3] sdl2: move SDL_* includes to sdl2.h Gerd Hoffmann
2014-12-11 12:32 ` [Qemu-devel] [RfC PATCH 0/3] sdl2: add opengl rendering support Daniel P. Berrange
2014-12-11 15:29   ` Gerd Hoffmann [this message]
2014-12-11 15:46     ` Daniel P. Berrange
2014-12-11 15:54       ` Gerd Hoffmann
2014-12-11 13:28 ` Paolo Bonzini
2014-12-11 15:40   ` Gerd Hoffmann
2014-12-11 17:25     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418311740.1664.48.camel@nilsson.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=berrange@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).