From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: imammedo@redhat.com, andrey@xdel.ru, dgilbert@redhat.com,
batuzovk@ispras.ru
Subject: [Qemu-devel] [PATCH 0/3] serial: fixes for migration
Date: Thu, 11 Dec 2014 19:18:48 +0100 [thread overview]
Message-ID: <1418321931-12648-1-git-send-email-pbonzini@redhat.com> (raw)
While adding migration support for thr_ipending, I and Pavel chose
the default value of thr_ipending (absent the subsection) according
to what should be the common behavior of the serial device and its
drivers.
However, the condition did not actually match the common state of the
serial device because of emulation inaccuracies. Thus the subsection
is almost always transmitted, which breaks migration from 2.2 to 2.1.
Patch 3 fixes these inaccuracies, but unmasks a missed interrupt bug
that upsets Windows. In order to keep bisectability, that missed
interrupt is first fixed in patch 2. And to close the circle, patch 1
cleans up more code that didn't match the datasheet too well (and was
also unnecessarily complicated); that was the first, unfruitful attempt
to fix the bug.
Datasheet available at http://www.ti.com/lit/ds/symlink/pc16550d.pdf
Paolo Bonzini (3):
serial: fix THRE/TEMT handling
serial: update LSR on enabling/disabling FIFOs
serial: do not trigger THR interrupt after writing to IER
hw/char/serial.c | 34 ++++++++++++++++------------------
1 file changed, 16 insertions(+), 18 deletions(-)
--
1.8.3.1
next reply other threads:[~2014-12-11 18:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 18:18 Paolo Bonzini [this message]
2014-12-11 18:18 ` [Qemu-devel] [PATCH 1/3] serial: clean up THRE/TEMT handling Paolo Bonzini
2014-12-11 18:18 ` [Qemu-devel] [PATCH 2/3] serial: update LSR on enabling/disabling FIFOs Paolo Bonzini
2014-12-11 18:18 ` [Qemu-devel] [PATCH 3/3] serial: do not trigger THR interrupt after writing to IER Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418321931-12648-1-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=andrey@xdel.ru \
--cc=batuzovk@ispras.ru \
--cc=dgilbert@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).