From: Liang Li <liang.z.li@intel.com>
To: qemu-devel@nongnu.org
Cc: quintela@redhat.com, Liang Li <liang.z.li@intel.com>,
armbru@redhat.com, lcapitulino@redhat.com,
yang.z.zhang@intel.com, dgilbert@redhat.com
Subject: [Qemu-devel] [v3 13/13] migration: Add command to query migration parameter
Date: Fri, 12 Dec 2014 09:29:06 +0800 [thread overview]
Message-ID: <1418347746-15829-14-git-send-email-liang.z.li@intel.com> (raw)
In-Reply-To: <1418347746-15829-1-git-send-email-liang.z.li@intel.com>
Add the qmp and hmp commands to query the parameters used in live
migration.
Signed-off-by: Liang Li <liang.z.li@intel.com>
Signed-off-by: Yang Zhang <yang.z.zhang@intel.com>
---
hmp-commands.hx | 2 ++
hmp.c | 19 +++++++++++++++++++
hmp.h | 1 +
migration.c | 25 +++++++++++++++++++++++++
monitor.c | 7 +++++++
qapi-schema.json | 10 ++++++++++
qmp-commands.hx | 24 ++++++++++++++++++++++++
7 files changed, 88 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 535b5ba..ed0c06a 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1779,6 +1779,8 @@ show user network stack connection states
show migration status
@item info migrate_capabilities
show current migration capabilities
+@item info migrate_parameters
+show current migration parameters
@item info migrate_cache_size
show current migration XBZRLE cache size
@item info balloon
diff --git a/hmp.c b/hmp.c
index 965c037..b321b15 100644
--- a/hmp.c
+++ b/hmp.c
@@ -246,6 +246,25 @@ void hmp_info_migrate_capabilities(Monitor *mon, const QDict *qdict)
qapi_free_MigrationCapabilityStatusList(caps);
}
+void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)
+{
+ MigrationParameterStatusList *params, *p;
+
+ params = qmp_query_migrate_parameters(NULL);
+
+ if (params) {
+ monitor_printf(mon, "parameters: ");
+ for (p = params; p; p = p->next) {
+ monitor_printf(mon, "%s: %d ",
+ MigrationParameter_lookup[p->value->parameter],
+ (int)p->value->value);
+ }
+ monitor_printf(mon, "\n");
+ }
+
+ qapi_free_MigrationParameterStatusList(params);
+}
+
void hmp_info_migrate_cache_size(Monitor *mon, const QDict *qdict)
{
monitor_printf(mon, "xbzrel cache size: %" PRId64 " kbytes\n",
diff --git a/hmp.h b/hmp.h
index bd1b203..471417c 100644
--- a/hmp.h
+++ b/hmp.h
@@ -28,6 +28,7 @@ void hmp_info_chardev(Monitor *mon, const QDict *qdict);
void hmp_info_mice(Monitor *mon, const QDict *qdict);
void hmp_info_migrate(Monitor *mon, const QDict *qdict);
void hmp_info_migrate_capabilities(Monitor *mon, const QDict *qdict);
+void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict);
void hmp_info_migrate_cache_size(Monitor *mon, const QDict *qdict);
void hmp_info_cpus(Monitor *mon, const QDict *qdict);
void hmp_info_block(Monitor *mon, const QDict *qdict);
diff --git a/migration.c b/migration.c
index d3d377e..f87aba3 100644
--- a/migration.c
+++ b/migration.c
@@ -179,6 +179,31 @@ MigrationCapabilityStatusList *qmp_query_migrate_capabilities(Error **errp)
return head;
}
+MigrationParameterStatusList *qmp_query_migrate_parameters(Error **errp)
+{
+ MigrationParameterStatusList *head = NULL;
+ MigrationParameterStatusList *params;
+ MigrationState *s = migrate_get_current();
+ int i;
+
+ params = NULL; /* silence compiler warning */
+ for (i = 0; i < MIGRATION_PARAMETER_MAX; i++) {
+ if (head == NULL) {
+ head = g_malloc0(sizeof(*params));
+ params = head;
+ } else {
+ params->next = g_malloc0(sizeof(*params));
+ params = params->next;
+ }
+ params->value =
+ g_malloc(sizeof(*params->value));
+ params->value->parameter = i;
+ params->value->value = s->parameters[i];
+ }
+
+ return head;
+}
+
static void get_xbzrle_cache_stats(MigrationInfo *info)
{
if (migrate_use_xbzrle()) {
diff --git a/monitor.c b/monitor.c
index 4cf62b6..6ab269f 100644
--- a/monitor.c
+++ b/monitor.c
@@ -2862,6 +2862,13 @@ static mon_cmd_t info_cmds[] = {
.mhandler.cmd = hmp_info_migrate_capabilities,
},
{
+ .name = "migrate_parameters",
+ .args_type = "",
+ .params = "",
+ .help = "show current migration parameters",
+ .mhandler.cmd = hmp_info_migrate_parameters,
+ },
+ {
.name = "migrate_cache_size",
.args_type = "",
.params = "",
diff --git a/qapi-schema.json b/qapi-schema.json
index 2caeccc..ccdb6b2 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -584,6 +584,16 @@
{ 'command': 'migrate-set-parameters',
'data': { 'parameters': ['MigrationParameterStatus'] } }
##
+# @query-migrate-parameters
+#
+# Returns information about the current migration parameters status
+#
+# Returns: @MigrationParametersStatus
+#
+# Since: 2.3
+##
+{ 'command': 'query-migrate-parameters', 'returns': ['MigrationParameterStatus']}
+##
##
# @MouseInfo:
#
diff --git a/qmp-commands.hx b/qmp-commands.hx
index 59d2643..986eb95 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -3248,6 +3248,30 @@ EQMP
.mhandler.cmd_new = qmp_marshal_input_migrate_set_parameters,
},
SQMP
+query-migrate-parameters
+------------------------
+
+Query current migration parameters
+
+- "parameters": migration parameters value
+ - "compress-level" : compress level value (json-int)
+
+Arguments:
+
+Example:
+
+-> { "execute": "query-migrate-parameters" }
+<- { "return": [ { "value": 1, "parameter": "compress-level" } ] }
+
+EQMP
+
+ {
+ .name = "query-migrate-parameters",
+ .args_type = "",
+ .mhandler.cmd_new = qmp_marshal_input_query_migrate_parameters,
+ },
+
+SQMP
query-balloon
-------------
--
1.8.3.1
next prev parent reply other threads:[~2014-12-12 1:36 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 1:28 [Qemu-devel] [PATCH v3 0/13] migration: Add a new feature to do live migration Liang Li
2014-12-12 1:28 ` [Qemu-devel] [v3 01/13] docs: Add a doc about multiple thread compression Liang Li
2015-01-23 13:17 ` Dr. David Alan Gilbert
2015-01-23 15:24 ` Eric Blake
2014-12-12 1:28 ` [Qemu-devel] [v3 02/13] migration: Add the framework of multi-thread compression Liang Li
2015-01-23 13:23 ` Dr. David Alan Gilbert
2015-01-23 16:09 ` Eric Blake
2014-12-12 1:28 ` [Qemu-devel] [v3 03/13] migration: Add the framework of muti-thread decompression Liang Li
2015-01-23 13:26 ` Dr. David Alan Gilbert
2015-01-23 16:22 ` Eric Blake
2014-12-12 1:28 ` [Qemu-devel] [v3 04/13] qemu-file: Add tow function will be used in migration Liang Li
2015-01-23 13:31 ` Dr. David Alan Gilbert
2015-01-24 13:42 ` Li, Liang Z
2014-12-12 1:28 ` [Qemu-devel] [v3 05/13] arch_init: alloc and free data struct in multi-thread compression Liang Li
2015-01-23 13:35 ` Dr. David Alan Gilbert
2015-01-24 13:46 ` Li, Liang Z
2014-12-12 1:28 ` [Qemu-devel] [v3 06/13] arch_init: Add data struct used by decompression Liang Li
2014-12-12 1:29 ` [Qemu-devel] [v3 07/13] migraion: Rewrite the function ram_save_page() Liang Li
2015-01-23 13:38 ` Dr. David Alan Gilbert
2014-12-12 1:29 ` [Qemu-devel] [v3 08/13] migration: Add the core code of multi-thread compresion Liang Li
2015-01-23 13:39 ` Dr. David Alan Gilbert
2015-01-24 13:51 ` Li, Liang Z
2014-12-12 1:29 ` [Qemu-devel] [v3 09/13] migration: Make compression co-work with xbzrle Liang Li
2015-01-23 13:40 ` Dr. David Alan Gilbert
2014-12-12 1:29 ` [Qemu-devel] [v3 10/13] migration: Add the core code of multi-thread decompression Liang Li
2015-01-23 13:42 ` Dr. David Alan Gilbert
2014-12-12 1:29 ` [Qemu-devel] [v3 11/13] migration: Add interface to control compression Liang Li
2015-01-23 13:44 ` Dr. David Alan Gilbert
2015-01-23 15:26 ` Eric Blake
2014-12-12 1:29 ` [Qemu-devel] [v3 12/13] migration: Add command to set migration parameter Liang Li
2015-01-23 13:48 ` Dr. David Alan Gilbert
2015-01-23 15:42 ` Eric Blake
2015-01-23 15:59 ` Dr. David Alan Gilbert
2015-01-23 16:06 ` Eric Blake
2015-01-24 14:14 ` Li, Liang Z
2015-01-26 9:22 ` Dr. David Alan Gilbert
2015-01-23 15:39 ` Eric Blake
2014-12-12 1:29 ` Liang Li [this message]
2015-01-23 13:49 ` [Qemu-devel] [v3 13/13] migration: Add command to query " Dr. David Alan Gilbert
2015-01-23 15:47 ` Eric Blake
2014-12-24 5:08 ` [Qemu-devel] [PATCH v3 0/13] migration: Add a new feature to do live migration Li, Liang Z
2015-01-07 3:12 ` Li, Liang Z
2015-01-23 13:10 ` Dr. David Alan Gilbert
2015-01-24 13:25 ` Li, Liang Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418347746-15829-14-git-send-email-liang.z.li@intel.com \
--to=liang.z.li@intel.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).