From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>,
Anthony Liguori <aliguori@amazon.com>,
Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH 1/2] sdl2: Use correct sdl2_console for window events
Date: Fri, 12 Dec 2014 10:52:51 +0100 [thread overview]
Message-ID: <1418377972-25278-2-git-send-email-mreitz@redhat.com> (raw)
In-Reply-To: <1418377972-25278-1-git-send-email-mreitz@redhat.com>
SDL_PollEvent() polls events for all windows; therefore,
sdl2_poll_events() will poll the events for all windows and not only for
the one identified by the given sdl2_console.
This should be considered in handle_windowevent(): The window affected
by the event is not necessarily the one identified by the sdl2_console
object given to sdl2_poll_events(), but the one identified by
ev->window.windowID.
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
ui/sdl2.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/ui/sdl2.c b/ui/sdl2.c
index a1def81..fdc762f 100644
--- a/ui/sdl2.c
+++ b/ui/sdl2.c
@@ -507,8 +507,10 @@ static void handle_mousewheel(SDL_Event *ev)
qemu_input_event_sync();
}
-static void handle_windowevent(struct sdl2_console *scon, SDL_Event *ev)
+static void handle_windowevent(SDL_Event *ev)
{
+ struct sdl2_console *scon = get_scon_from_window(ev->window.windowID);
+
switch (ev->window.event) {
case SDL_WINDOWEVENT_RESIZED:
{
@@ -586,7 +588,7 @@ void sdl2_poll_events(struct sdl2_console *scon)
handle_mousewheel(ev);
break;
case SDL_WINDOWEVENT:
- handle_windowevent(scon, ev);
+ handle_windowevent(ev);
break;
default:
break;
--
1.9.3
next prev parent reply other threads:[~2014-12-12 9:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 9:52 [Qemu-devel] [PATCH 0/2] sdl2: Work around SDL2 SDL_ShowWindow() bug Max Reitz
2014-12-12 9:52 ` Max Reitz [this message]
2014-12-12 9:52 ` [Qemu-devel] [PATCH 2/2] " Max Reitz
2014-12-12 11:17 ` [Qemu-devel] [PATCH 0/2] " Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418377972-25278-2-git-send-email-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=aliguori@amazon.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).