From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43882)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XzNcN-0005bb-FH
	for qemu-devel@nongnu.org; Fri, 12 Dec 2014 05:38:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XzNcH-0001dC-AZ
	for qemu-devel@nongnu.org; Fri, 12 Dec 2014 05:38:39 -0500
Received: from mx1.redhat.com ([209.132.183.28]:57654)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XzNcH-0001d3-2P
	for qemu-devel@nongnu.org; Fri, 12 Dec 2014 05:38:33 -0500
Message-ID: <1418380707.23141.4.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Fri, 12 Dec 2014 11:38:27 +0100
In-Reply-To: <5489A396.5090504@redhat.com>
References: <1418294973-21790-1-git-send-email-kraxel@redhat.com>
	<1418294973-21790-4-git-send-email-kraxel@redhat.com>
	<5489A396.5090504@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 03/10] sdl2: move keyboard input code to
 new sdl2-input.c
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>

  Hi,

> > +static uint8_t modifiers_state[SDL_NUM_SCANCODES];
> > +
> > +void sdl2_reset_keys(struct sdl2_console *scon)
> > +{
> > +    QemuConsole *con = scon ? scon->dcl.con : NULL;
> > +    int i;
> > +
> > +    for (i = 0; i < 256; i++) {
> 
> Should this be SDL_NUM_SCANCODES?

Yes, fixed.

thanks,
  Gerd