qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PULL 03/19] iotests: Add test for vmdk JSON file names
Date: Fri, 12 Dec 2014 17:09:49 +0000	[thread overview]
Message-ID: <1418404205-6213-4-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1418404205-6213-1-git-send-email-stefanha@redhat.com>

From: Max Reitz <mreitz@redhat.com>

Add a test for vmdk files which use a file with a JSON file name, and
which then try to open extents. That should fail and the error message
should at least try to look helpful.

Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Message-id: 1417615043-26174-3-git-send-email-mreitz@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 tests/qemu-iotests/059     | 6 ++++++
 tests/qemu-iotests/059.out | 4 ++++
 2 files changed, 10 insertions(+)

diff --git a/tests/qemu-iotests/059 b/tests/qemu-iotests/059
index 2ed1a7f..50ca5ce 100755
--- a/tests/qemu-iotests/059
+++ b/tests/qemu-iotests/059
@@ -111,6 +111,12 @@ $QEMU_IO -f qcow2 -c "write -P 0xb 10240 512" "$TEST_IMG.qcow2" | _filter_qemu_i
 $QEMU_IMG convert -f qcow2 -O vmdk -o subformat=streamOptimized "$TEST_IMG.qcow2" "$TEST_IMG" 2>&1
 
 echo
+echo "=== Testing monolithicFlat with internally generated JSON file name ==="
+IMGOPTS="subformat=monolithicFlat" _make_test_img 64M
+$QEMU_IO -c "open -o driver=$IMGFMT,file.driver=blkdebug,file.image.filename=$TEST_IMG,file.inject-error.0.event=read_aio" 2>&1 \
+    | _filter_testdir | _filter_imgfmt
+
+echo
 echo "=== Testing version 3 ==="
 _use_sample_img iotest-version3.vmdk.bz2
 _img_info
diff --git a/tests/qemu-iotests/059.out b/tests/qemu-iotests/059.out
index 0dadba6..cbb0de4 100644
--- a/tests/qemu-iotests/059.out
+++ b/tests/qemu-iotests/059.out
@@ -2053,6 +2053,10 @@ wrote 512/512 bytes at offset 0
 wrote 512/512 bytes at offset 10240
 512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 
+=== Testing monolithicFlat with internally generated JSON file name ===
+Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
+qemu-io: can't open: Cannot use relative extent paths with VMDK descriptor file 'json:{"image": {"driver": "file", "filename": "TEST_DIR/t.IMGFMT"}, "driver": "blkdebug", "inject-error.0.event": "read_aio"}'
+
 === Testing version 3 ===
 image: TEST_DIR/iotest-version3.IMGFMT
 file format: IMGFMT
-- 
2.1.0

  parent reply	other threads:[~2014-12-12 17:10 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-12 17:09 [Qemu-devel] [PULL 00/19] Block patches Stefan Hajnoczi
2014-12-12 17:09 ` [Qemu-devel] [PULL 01/19] block migration: fix return value Stefan Hajnoczi
2014-12-12 17:09 ` [Qemu-devel] [PULL 02/19] vmdk: Fix error for JSON descriptor file names Stefan Hajnoczi
2014-12-12 17:09 ` Stefan Hajnoczi [this message]
2014-12-12 17:09 ` [Qemu-devel] [PULL 04/19] block/rbd: fix memory leak Stefan Hajnoczi
2014-12-12 17:09 ` [Qemu-devel] [PULL 05/19] block: vhdx - remove redundant comments Stefan Hajnoczi
2014-12-12 17:09 ` [Qemu-devel] [PULL 06/19] block: vhdx - update PAYLOAD_BLOCK_UNMAPPED value to match 1.00 spec Stefan Hajnoczi
2014-12-12 17:09 ` [Qemu-devel] [PULL 07/19] block: vhdx - change .vhdx_create default block state to ZERO Stefan Hajnoczi
2014-12-12 17:09 ` [Qemu-devel] [PULL 08/19] qemu-io: Add sigraise command Stefan Hajnoczi
2014-12-12 17:09 ` [Qemu-devel] [PULL 09/19] iotests: Filter for "Killed" in qemu-io output Stefan Hajnoczi
2014-12-12 17:09 ` [Qemu-devel] [PULL 10/19] iotests: Fix test 039 Stefan Hajnoczi
2014-12-12 17:09 ` [Qemu-devel] [PULL 11/19] block: vhdx - set .bdrv_has_zero_init to bdrv_has_zero_init_1 Stefan Hajnoczi
2014-12-12 17:09 ` [Qemu-devel] [PULL 12/19] qemu-iotests: Remove traling whitespaces in *.out Stefan Hajnoczi
2014-12-12 17:09 ` [Qemu-devel] [PULL 13/19] block: Don't add trailing space in "Formating..." message Stefan Hajnoczi
2014-12-12 17:10 ` [Qemu-devel] [PULL 14/19] block: drop unused bdrv_clear_incoming_migration_all() prototype Stefan Hajnoczi
2014-12-12 17:10 ` [Qemu-devel] [PULL 15/19] linux-aio: queue requests that cannot be submitted Stefan Hajnoczi
2014-12-12 17:10 ` [Qemu-devel] [PULL 16/19] linux-aio: track whether the queue is blocked Stefan Hajnoczi
2014-12-12 17:10 ` [Qemu-devel] [PULL 17/19] linux-aio: rename LaioQueue idx field to "n" Stefan Hajnoczi
2014-12-12 17:10 ` [Qemu-devel] [PULL 18/19] linux-aio: drop return code from laio_io_unplug and ioq_submit Stefan Hajnoczi
2014-12-12 17:10 ` [Qemu-devel] [PULL 19/19] linux-aio: simplify removal of completed iocbs from the list Stefan Hajnoczi
2014-12-15 11:11 ` [Qemu-devel] [PULL 00/19] Block patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418404205-6213-4-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).