qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: peter.maydell@linaro.org
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
	borntraeger@de.ibm.com, jfrei@linux.vnet.ibm.com,
	qemu-devel@nongnu.org, agraf@suse.de
Subject: [Qemu-devel] [PULL 04/11] s390x/ccw: fix oddity in machine class init
Date: Mon, 15 Dec 2014 12:35:25 +0100	[thread overview]
Message-ID: <1418643332-29100-5-git-send-email-cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <1418643332-29100-1-git-send-email-cornelia.huck@de.ibm.com>

ccw_machine_class_init() uses ',' instead of ';' while initializing
the class' fields. This is almost certainly a copy/paste error and,
while legal C, rather on the unusual side. Just use ';' everywhere.

Reviewed-by: Thomas Huth <thuth@linux.vnet.ibm.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Jens Freimann <jfrei@linux.vnet.ibm.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
 hw/s390x/s390-virtio-ccw.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index 0b8b42b..71bafe0 100644
--- a/hw/s390x/s390-virtio-ccw.c
+++ b/hw/s390x/s390-virtio-ccw.c
@@ -188,7 +188,7 @@ static void ccw_machine_class_init(ObjectClass *oc, void *data)
     mc->no_serial = 1;
     mc->no_parallel = 1;
     mc->no_sdcard = 1;
-    mc->use_sclp = 1,
+    mc->use_sclp = 1;
     mc->max_cpus = 255;
     nc->nmi_monitor_handler = s390_nmi;
 }
-- 
1.7.9.5

  parent reply	other threads:[~2014-12-15 11:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-15 11:35 [Qemu-devel] [PULL 00/11] s390x changes for 2.3 Cornelia Huck
2014-12-15 11:35 ` [Qemu-devel] [PULL 01/11] s390: Add PCI bus support Cornelia Huck
2014-12-15 11:35 ` [Qemu-devel] [PULL 02/11] s390: implement pci instructions Cornelia Huck
2014-12-15 11:35 ` [Qemu-devel] [PULL 03/11] kvm: extend kvm_irqchip_add_msi_route to work on s390 Cornelia Huck
2014-12-15 11:35 ` Cornelia Huck [this message]
2014-12-15 11:35 ` [Qemu-devel] [PULL 05/11] s390x/css: Clean up unnecessary CONFIG_USER_ONLY wrappers Cornelia Huck
2014-12-15 11:35 ` [Qemu-devel] [PULL 06/11] s390x/kvm: sync register support helper function Cornelia Huck
2014-12-15 11:35 ` [Qemu-devel] [PULL 07/11] s390x/kvm: avoid syscalls by syncing registers with kvm_run Cornelia Huck
2014-12-15 11:35 ` [Qemu-devel] [PULL 08/11] s390/pci: add error event support Cornelia Huck
2014-12-15 11:35 ` [Qemu-devel] [PULL 09/11] s390/pci: implement stpcifc instruction Cornelia Huck
2014-12-15 11:35 ` [Qemu-devel] [PULL 10/11] s390/pci: remove unnecessary cpu_synchronize_state Cornelia Huck
2014-12-15 11:35 ` [Qemu-devel] [PULL 11/11] s390x: update MAINTAINERS Cornelia Huck
2014-12-15 13:10 ` [Qemu-devel] [PULL 00/11] s390x changes for 2.3 Peter Maydell
2014-12-15 13:48   ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418643332-29100-5-git-send-email-cornelia.huck@de.ibm.com \
    --to=cornelia.huck@de.ibm.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=jfrei@linux.vnet.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).