From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46548) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0TwR-0006e3-3x for qemu-devel@nongnu.org; Mon, 15 Dec 2014 06:36:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0TwF-0005aa-AH for qemu-devel@nongnu.org; Mon, 15 Dec 2014 06:35:55 -0500 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:55159) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0TwE-0005a1-TL for qemu-devel@nongnu.org; Mon, 15 Dec 2014 06:35:43 -0500 Received: from /spool/local by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 15 Dec 2014 11:35:41 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 12E822190045 for ; Mon, 15 Dec 2014 11:35:10 +0000 (GMT) Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id sBFBZd1S53542946 for ; Mon, 15 Dec 2014 11:35:39 GMT Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id sBFBZcfx018764 for ; Mon, 15 Dec 2014 04:35:39 -0700 From: Cornelia Huck Date: Mon, 15 Dec 2014 12:35:25 +0100 Message-Id: <1418643332-29100-5-git-send-email-cornelia.huck@de.ibm.com> In-Reply-To: <1418643332-29100-1-git-send-email-cornelia.huck@de.ibm.com> References: <1418643332-29100-1-git-send-email-cornelia.huck@de.ibm.com> Subject: [Qemu-devel] [PULL 04/11] s390x/ccw: fix oddity in machine class init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: peter.maydell@linaro.org Cc: Cornelia Huck , borntraeger@de.ibm.com, jfrei@linux.vnet.ibm.com, qemu-devel@nongnu.org, agraf@suse.de ccw_machine_class_init() uses ',' instead of ';' while initializing the class' fields. This is almost certainly a copy/paste error and, while legal C, rather on the unusual side. Just use ';' everywhere. Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck Signed-off-by: Jens Freimann Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio-ccw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index 0b8b42b..71bafe0 100644 --- a/hw/s390x/s390-virtio-ccw.c +++ b/hw/s390x/s390-virtio-ccw.c @@ -188,7 +188,7 @@ static void ccw_machine_class_init(ObjectClass *oc, void *data) mc->no_serial = 1; mc->no_parallel = 1; mc->no_sdcard = 1; - mc->use_sclp = 1, + mc->use_sclp = 1; mc->max_cpus = 255; nc->nmi_monitor_handler = s390_nmi; } -- 1.7.9.5