From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0ag0-0002K6-8T for qemu-devel@nongnu.org; Mon, 15 Dec 2014 13:47:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0aft-0004Zw-VN for qemu-devel@nongnu.org; Mon, 15 Dec 2014 13:47:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33549) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0aft-0004Zp-NJ for qemu-devel@nongnu.org; Mon, 15 Dec 2014 13:47:17 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBFIlGZa019105 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 15 Dec 2014 13:47:17 -0500 From: Eduardo Habkost Date: Mon, 15 Dec 2014 16:44:57 -0200 Message-Id: <1418669099-30322-5-git-send-email-ehabkost@redhat.com> In-Reply-To: <1418669099-30322-1-git-send-email-ehabkost@redhat.com> References: <1418669099-30322-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [PATCH v4 4/6] target-i386: Isolate enabled-by-default features to a separate array List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Igor Mammedov This will make it easier to write unit tests for the feature initialization logic. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index e9df33e..b6b3c4f 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -464,6 +464,11 @@ static uint32_t kvm_default_unset_features[FEATURE_WORDS] = { [FEAT_8000_0001_ECX] = CPUID_EXT3_SVM, }; +/* Features that are added by default to all CPU models in any accelerator: */ +FeatureWordArray default_features_all = { + [FEAT_1_ECX] = CPUID_EXT_HYPERVISOR, +}; + void x86_cpu_compat_kvm_no_autoenable(FeatureWord w, uint32_t features) { kvm_default_features[w] &= ~features; @@ -2005,15 +2010,14 @@ static void x86_cpu_load_def(X86CPU *cpu, X86CPUDefinition *def, Error **errp) } /* Special cases not set in the X86CPUDefinition structs: */ - if (kvm_enabled()) { - FeatureWord w; - for (w = 0; w < FEATURE_WORDS; w++) { + for (w = 0; w < FEATURE_WORDS; w++) { + if (kvm_enabled()) { env->features[w] |= kvm_default_features[w]; env->features[w] &= ~kvm_default_unset_features[w]; } + env->features[w] |= default_features_all[w]; } - env->features[FEAT_1_ECX] |= CPUID_EXT_HYPERVISOR; /* sysenter isn't supported in compatibility mode on AMD, * syscall isn't supported in compatibility mode on Intel. -- 1.9.3