* [Qemu-devel] [PATCH] target-tricore: Fix mask handling JNZ.T being 7 bit long
@ 2014-12-15 21:42 Bastian Koppelmann
0 siblings, 0 replies; only message in thread
From: Bastian Koppelmann @ 2014-12-15 21:42 UTC (permalink / raw)
To: qemu-devel; +Cc: rth
The mask is actually 7 bit long, instead of 6, so the expression checking
for JNZ.T is always false. Let's make the mask 1 bit wider.
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
---
target-tricore/translate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-tricore/translate.c b/target-tricore/translate.c
index d1b845b..af42408 100644
--- a/target-tricore/translate.c
+++ b/target-tricore/translate.c
@@ -3825,8 +3825,8 @@ static void decode_32Bit_opc(CPUTriCoreState *env, DisasContext *ctx)
op1 = MASK_OP_MAJOR(ctx->opcode);
- /* handle JNZ.T opcode only being 6 bit long */
- if (unlikely((op1 & 0x3f) == OPCM_32_BRN_JTT)) {
+ /* handle JNZ.T opcode only being 7 bit long */
+ if (unlikely((op1 & 0x7f) == OPCM_32_BRN_JTT)) {
op1 = OPCM_32_BRN_JTT;
}
--
2.1.3
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2014-12-15 20:42 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-15 21:42 [Qemu-devel] [PATCH] target-tricore: Fix mask handling JNZ.T being 7 bit long Bastian Koppelmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).