From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Markus Armbruster <armbru@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] paaudio race condition on close
Date: Tue, 16 Dec 2014 07:37:25 +0100 [thread overview]
Message-ID: <1418711845.9400.6.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <CAFEAcA-wektgbktxM25Ka37zvQhsSMdHS-Pxu0LKtaZQYtpppw@mail.gmail.com>
On Mo, 2014-12-15 at 15:37 +0000, Peter Maydell wrote:
> On 15 December 2014 at 09:23, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> >> > Does anybody know how this is supposed to work? Is the fix as
> >> > simple as just moving the free_resources call below the fini?
> >
> > I suspect the code simply wasn't written with threads in mind and the
> > fix actually is that simple ...
> >
> > The submitted patch looks fine to me.
>
> Can I take that as a reviewed-by? :-)
Sure.
>
> > Do you just commit it yourself?
> > I don't have any other audio stuff pending atm.
>
> I'm happy to put it in via target-arm (the board where I
> found this, musicpal, is an ARM one).
Ok.
cheers,
Gerd
prev parent reply other threads:[~2014-12-16 6:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 16:47 [Qemu-devel] paaudio race condition on close Peter Maydell
2014-12-15 9:08 ` Markus Armbruster
2014-12-15 9:23 ` Gerd Hoffmann
2014-12-15 15:37 ` Peter Maydell
2014-12-16 6:37 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418711845.9400.6.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).