From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40184)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Y0llL-0003VH-1x
	for qemu-devel@nongnu.org; Tue, 16 Dec 2014 01:37:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Y0llE-0001BP-PA
	for qemu-devel@nongnu.org; Tue, 16 Dec 2014 01:37:39 -0500
Received: from mx1.redhat.com ([209.132.183.28]:56899)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Y0llE-0001Av-H2
	for qemu-devel@nongnu.org; Tue, 16 Dec 2014 01:37:32 -0500
Message-ID: <1418711845.9400.6.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 16 Dec 2014 07:37:25 +0100
In-Reply-To: <CAFEAcA-wektgbktxM25Ka37zvQhsSMdHS-Pxu0LKtaZQYtpppw@mail.gmail.com>
References: <CAFEAcA9YQR8A13oy07TfRC_q6LhyVP5YaWjniKLh1-WdKxOOPg@mail.gmail.com>
	<87fvchffgo.fsf@blackfin.pond.sub.org>
	<1418635433.9400.5.camel@nilsson.home.kraxel.org>
	<CAFEAcA-wektgbktxM25Ka37zvQhsSMdHS-Pxu0LKtaZQYtpppw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] paaudio race condition on close
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Markus Armbruster <armbru@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

On Mo, 2014-12-15 at 15:37 +0000, Peter Maydell wrote:
> On 15 December 2014 at 09:23, Gerd Hoffmann <kraxel@redhat.com> wrote:
> 
> >> > Does anybody know how this is supposed to work? Is the fix as
> >> > simple as just moving the free_resources call below the fini?
> >
> > I suspect the code simply wasn't written with threads in mind and the
> > fix actually is that simple ...
> >
> > The submitted patch looks fine to me.
> 
> Can I take that as a reviewed-by? :-)

Sure.

> 
> > Do you just commit it yourself?
> > I don't have any other audio stuff pending atm.
> 
> I'm happy to put it in via target-arm (the board where I
> found this, musicpal, is an ARM one).

Ok.

cheers,
  Gerd