From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47551) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0y8F-0004Ww-Uf for qemu-devel@nongnu.org; Tue, 16 Dec 2014 14:50:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0y8B-0002Vv-AI for qemu-devel@nongnu.org; Tue, 16 Dec 2014 14:50:07 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:53046) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0y8B-0002T7-2o for qemu-devel@nongnu.org; Tue, 16 Dec 2014 14:50:03 -0500 From: Leon Alrae Date: Tue, 16 Dec 2014 19:48:48 +0000 Message-ID: <1418759356-14242-3-git-send-email-leon.alrae@imgtec.com> In-Reply-To: <1418759356-14242-1-git-send-email-leon.alrae@imgtec.com> References: <1418759356-14242-1-git-send-email-leon.alrae@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PULL 02/30] target-mips: Make CP1.FIR read-only here too List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: "Maciej W. Rozycki" From: "Maciej W. Rozycki" CP1.FIR is read-only in hardware so gdbstub must respect it. We already respect it for CTC1 instructions, so do it here too. Signed-off-by: Maciej W. Rozycki Reviewed-by: Leon Alrae Signed-off-by: Leon Alrae --- target-mips/gdbstub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-mips/gdbstub.c b/target-mips/gdbstub.c index 7e3a604..e86df0e 100644 --- a/target-mips/gdbstub.c +++ b/target-mips/gdbstub.c @@ -105,7 +105,7 @@ int mips_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n) RESTORE_ROUNDING_MODE; break; case 71: - env->active_fpu.fcr0 = tmp; + /* FIR is read-only. Ignore writes. */ break; } return sizeof(target_ulong); -- 2.1.0