From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, mst@redhat.com, armbru@redhat.com,
mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com,
John Snow <jsnow@redhat.com>
Subject: [Qemu-devel] [PATCH v2 00/17] ide: rerror and werror support for IDE and AHCI
Date: Tue, 16 Dec 2014 20:35:50 -0500 [thread overview]
Message-ID: <1418780167-16231-1-git-send-email-jsnow@redhat.com> (raw)
This series was written mostly by Paolo Bonzini to do two things:
1. Unify the restart callbacks for ISA, AHCI and BMDMA
2. Ensure we can restart a command after migration
Many of the early patches only make much sense considering the
end-goal of eliminating BMDMA specific restart code to be shared
with ISA and AHCI codepaths.
Migration for halted commands is fixed for ISA, PCI and AHCI.
As a consequence, operations halted via rerror=stop or werror=stop
should be able to be successfully migrated and resumed when using
ISA, PCI, or AHCI.
This series includes tests for ISA and PCI/BMDMA, but does not
yet include tests for AHCI, which require some more qtest work
to be upstreamed first. Regardless, the AHCI tests have been
written and can be observed at:
https://github.com/jnsnow/qemu/commits/ahci-devel-latest
See "ahci: add migrate dma test" and "ahci-test: add flush migrate test"
for the WIP versions of the AHCI test that I used to exercise this
patchset.
John Snow (3):
ahci: Migrate IDEStatus
ahci: Recompute cur_cmd on migrate post load
qtest/ide: Test flush / retry for ISA and PCI
Paolo Bonzini (14):
ide: start extracting ide_restart_dma out of bmdma_restart_dma
ide: prepare to move restart to common code
ide: introduce ide_register_restart_cb
ide: do not use BMDMA in restart callback
ide: pass IDEBus to the restart_cb
ide: move restart callback to common code
ide: remove restart_cb callback
ide: replace set_unit callback with more IDEBus state
ide: place initial state of the current request to IDEBus
ide: migrate initial request state via IDEBus
ide: commonize io_buffer_index initialization
ide: make more functions static
ide: support PIO restart for the ISA controller
ahci: add support for restarting non-queued commands
hw/ide/ahci.c | 37 +++++++++---------
hw/ide/atapi.c | 3 +-
hw/ide/cmd646.c | 3 +-
hw/ide/core.c | 109 +++++++++++++++++++++++++++++++++++++++++++++++-------
hw/ide/internal.h | 16 +++++---
hw/ide/isa.c | 3 +-
hw/ide/macio.c | 6 ---
hw/ide/pci.c | 98 ++++++++----------------------------------------
hw/ide/pci.h | 12 +++---
hw/ide/piix.c | 3 +-
hw/ide/via.c | 3 +-
tests/ide-test.c | 20 +++++++---
12 files changed, 165 insertions(+), 148 deletions(-)
--
1.9.3
next reply other threads:[~2014-12-17 1:36 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 1:35 John Snow [this message]
2014-12-17 1:35 ` [Qemu-devel] [PATCH v2 01/17] ide: start extracting ide_restart_dma out of bmdma_restart_dma John Snow
2014-12-17 1:35 ` [Qemu-devel] [PATCH v2 02/17] ide: prepare to move restart to common code John Snow
2014-12-17 1:35 ` [Qemu-devel] [PATCH v2 03/17] ide: introduce ide_register_restart_cb John Snow
2014-12-17 1:35 ` [Qemu-devel] [PATCH v2 04/17] ide: do not use BMDMA in restart callback John Snow
2014-12-17 1:35 ` [Qemu-devel] [PATCH v2 05/17] ide: pass IDEBus to the restart_cb John Snow
2014-12-17 1:35 ` [Qemu-devel] [PATCH v2 06/17] ide: move restart callback to common code John Snow
2014-12-17 1:35 ` [Qemu-devel] [PATCH v2 07/17] ide: remove restart_cb callback John Snow
2014-12-17 1:35 ` [Qemu-devel] [PATCH v2 08/17] ide: replace set_unit callback with more IDEBus state John Snow
2014-12-17 1:35 ` [Qemu-devel] [PATCH v2 09/17] ide: place initial state of the current request to IDEBus John Snow
2014-12-17 1:36 ` [Qemu-devel] [PATCH v2 10/17] ide: migrate initial request state via IDEBus John Snow
2014-12-17 1:36 ` [Qemu-devel] [PATCH v2 11/17] ide: commonize io_buffer_index initialization John Snow
2014-12-17 1:36 ` [Qemu-devel] [PATCH v2 12/17] ide: make more functions static John Snow
2014-12-17 1:36 ` [Qemu-devel] [PATCH v2 13/17] ide: support PIO restart for the ISA controller John Snow
2014-12-17 1:36 ` [Qemu-devel] [PATCH v2 14/17] ahci: Migrate IDEStatus John Snow
2014-12-17 1:49 ` John Snow
2015-01-30 9:35 ` Paolo Bonzini
2014-12-17 1:36 ` [Qemu-devel] [PATCH v2 15/17] ahci: add support for restarting non-queued commands John Snow
2014-12-17 9:41 ` Paolo Bonzini
2014-12-17 1:36 ` [Qemu-devel] [PATCH v2 16/17] ahci: Recompute cur_cmd on migrate post load John Snow
2015-01-30 9:36 ` Paolo Bonzini
2015-02-10 9:56 ` Stefan Hajnoczi
2015-02-10 15:11 ` John Snow
2014-12-17 1:36 ` [Qemu-devel] [PATCH v2 17/17] qtest/ide: Test flush / retry for ISA and PCI John Snow
2015-01-30 9:37 ` Paolo Bonzini
2014-12-17 8:23 ` [Qemu-devel] [PATCH v2 00/17] ide: rerror and werror support for IDE and AHCI Markus Armbruster
2014-12-17 9:37 ` Paolo Bonzini
2014-12-18 1:40 ` John Snow
2015-01-30 0:44 ` John Snow
2015-01-30 9:38 ` Paolo Bonzini
2015-01-30 16:48 ` John Snow
2015-02-10 9:59 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418780167-16231-1-git-send-email-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).