From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56600)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Y1AFy-0000Gh-JH
	for qemu-devel@nongnu.org; Wed, 17 Dec 2014 03:47:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Y1AFr-0002JV-QY
	for qemu-devel@nongnu.org; Wed, 17 Dec 2014 03:46:54 -0500
Received: from mx1.redhat.com ([209.132.183.28]:43115)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Y1AFr-0002JR-Ic
	for qemu-devel@nongnu.org; Wed, 17 Dec 2014 03:46:47 -0500
Message-ID: <1418802390.18828.9.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 17 Dec 2014 08:46:30 +0100
In-Reply-To: <5490FCA4.7040302@huawei.com>
References: <1418736006-30264-1-git-send-email-kraxel@redhat.com>
	<1418736006-30264-5-git-send-email-kraxel@redhat.com>
	<5490FCA4.7040302@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 04/10] vnc: switch to QemuOpts,
 allow multiple servers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gonglei <arei.gonglei@huawei.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>, Luiz Capitulino <lcapitulino@redhat.com>

On Mi, 2014-12-17 at 11:46 +0800, Gonglei wrote:
> On 2014/12/16 21:20, Gerd Hoffmann wrote:
> 
> > This patch switches vnc over to QemuOpts, and it (more or less
> > as side effect) allows multiple vnc server instances.
> > 
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > ---
> >  include/ui/console.h |   4 +-
> >  qmp.c                |  15 ++-
> >  ui/vnc.c             | 271 ++++++++++++++++++++++++++++++++-------------------
> >  vl.c                 |  42 +++-----
> >  4 files changed, 200 insertions(+), 132 deletions(-)
> > 
> 
> Hi, Gerd
> I'm afraid you forgot to update this patch following comments of version 2. :)

Oops, those fixups ended up in the wrong patch (#9).  I'll correct it.

cheers,
  Gerd