From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39441) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1Lrp-0002JV-Ak for qemu-devel@nongnu.org; Wed, 17 Dec 2014 16:10:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y1Lrj-00088E-6a for qemu-devel@nongnu.org; Wed, 17 Dec 2014 16:10:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52301) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1Lri-000887-Oh for qemu-devel@nongnu.org; Wed, 17 Dec 2014 16:10:38 -0500 From: Laszlo Ersek Date: Wed, 17 Dec 2014 22:10:05 +0100 Message-Id: <1418850613-26821-4-git-send-email-lersek@redhat.com> In-Reply-To: <1418850613-26821-1-git-send-email-lersek@redhat.com> References: <1418850613-26821-1-git-send-email-lersek@redhat.com> Subject: [Qemu-devel] [PATCH v5 03/11] fw_cfg_mem: max access size and region size are the same for data register List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: peter.maydell@linaro.org, qemu-devel@nongnu.org, rjones@redhat.com, drjones@redhat.com, lersek@redhat.com, pbonzini@redhat.com, agraf@suse.de Make it clear that the maximum access size to the MMIO data register determines the full size of the memory region. Currently the max access size is 1. This patch doesn't change behavior. Signed-off-by: Laszlo Ersek --- Notes: v5: - Remove the "fw_cfg_data_mem_ops.impl.max_access_size = 1" initialization, because we won't ask the memory subsystem to split accesses for us. [Paolo, Peter] v4: - unchanged v3: - new in v3 [Drew Jones] hw/nvram/fw_cfg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index 880311c..5b4d9d4 100644 --- a/hw/nvram/fw_cfg.c +++ b/hw/nvram/fw_cfg.c @@ -30,9 +30,8 @@ #include "qemu/error-report.h" #include "qemu/config-file.h" #define FW_CFG_SIZE 2 -#define FW_CFG_DATA_SIZE 1 #define FW_CFG_NAME "fw_cfg" #define FW_CFG_PATH "/machine/" FW_CFG_NAME #define TYPE_FW_CFG "fw_cfg" @@ -701,9 +700,10 @@ static void fw_cfg_mem_realize(DeviceState *dev, Error **errp) sysbus_init_mmio(sbd, &s->ctl_iomem); sysbus_mmio_map(sbd, 0, s->ctl_addr); memory_region_init_io(&s->data_iomem, OBJECT(s), &fw_cfg_data_mem_ops, - FW_CFG(s), "fwcfg.data", FW_CFG_DATA_SIZE); + FW_CFG(s), "fwcfg.data", + fw_cfg_data_mem_ops.valid.max_access_size); sysbus_init_mmio(sbd, &s->data_iomem); sysbus_mmio_map(sbd, 1, s->data_addr); } -- 1.8.3.1