qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: peter.maydell@linaro.org, qemu-devel@nongnu.org,
	rjones@redhat.com, drjones@redhat.com, lersek@redhat.com,
	pbonzini@redhat.com, agraf@suse.de
Subject: [Qemu-devel] [PATCH v5 07/11] fw_cfg_mem: expose the "data_width" property with fw_cfg_init_mem_wide()
Date: Wed, 17 Dec 2014 22:10:09 +0100	[thread overview]
Message-ID: <1418850613-26821-8-git-send-email-lersek@redhat.com> (raw)
In-Reply-To: <1418850613-26821-1-git-send-email-lersek@redhat.com>

We rebase fw_cfg_init_mem() to the new function for compatibility with
current callers.

Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---

Notes:
    v5:
    - just rebased
    
    v4:
    - unchanged
    
    v3:
    - new in v3 [Drew Jones]

 include/hw/nvram/fw_cfg.h |  2 ++
 hw/nvram/fw_cfg.c         | 12 +++++++++---
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/include/hw/nvram/fw_cfg.h b/include/hw/nvram/fw_cfg.h
index a99586e..6d8a8ac 100644
--- a/include/hw/nvram/fw_cfg.h
+++ b/include/hw/nvram/fw_cfg.h
@@ -79,8 +79,10 @@ void fw_cfg_add_file_callback(FWCfgState *s, const char *filename,
 void *fw_cfg_modify_file(FWCfgState *s, const char *filename, void *data,
                          size_t len);
 FWCfgState *fw_cfg_init_io(uint32_t iobase);
 FWCfgState *fw_cfg_init_mem(hwaddr ctl_addr, hwaddr data_addr);
+FWCfgState *fw_cfg_init_mem_wide(hwaddr ctl_addr, hwaddr data_addr,
+                                 uint32_t data_width);
 
 FWCfgState *fw_cfg_find(void);
 
 #endif /* NO_QEMU_PROTOS */
diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
index 80f846f..33ffd0f 100644
--- a/hw/nvram/fw_cfg.c
+++ b/hw/nvram/fw_cfg.c
@@ -667,21 +667,27 @@ FWCfgState *fw_cfg_init_io(uint32_t iobase)
 
     return fw_cfg_init1(dev);
 }
 
-FWCfgState *fw_cfg_init_mem(hwaddr ctl_addr, hwaddr data_addr)
+FWCfgState *fw_cfg_init_mem_wide(hwaddr ctl_addr, hwaddr data_addr,
+                                 uint32_t data_width)
 {
     DeviceState *dev;
 
     dev = qdev_create(NULL, TYPE_FW_CFG_MEM);
     qdev_prop_set_uint64(dev, "ctl_addr", ctl_addr);
     qdev_prop_set_uint64(dev, "data_addr", data_addr);
-    qdev_prop_set_uint32(dev, "data_width",
-                         fw_cfg_data_mem_ops.valid.max_access_size);
+    qdev_prop_set_uint32(dev, "data_width", data_width);
 
     return fw_cfg_init1(dev);
 }
 
+FWCfgState *fw_cfg_init_mem(hwaddr ctl_addr, hwaddr data_addr)
+{
+    return fw_cfg_init_mem_wide(ctl_addr, data_addr,
+                                fw_cfg_data_mem_ops.valid.max_access_size);
+}
+
 
 FWCfgState *fw_cfg_find(void)
 {
     return FW_CFG(object_resolve_path(FW_CFG_PATH, NULL));
-- 
1.8.3.1

  parent reply	other threads:[~2014-12-17 21:11 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-17 21:10 [Qemu-devel] [PATCH v5 00/11] fw_cfg, bootorder, and UEFI+'-kernel' on arm/virt Laszlo Ersek
2014-12-17 21:10 ` [Qemu-devel] [PATCH v5 01/11] fw_cfg: hard separation between the MMIO and I/O port mappings Laszlo Ersek
2014-12-18 11:18   ` Paolo Bonzini
2014-12-18 12:58     ` Peter Maydell
2014-12-18 13:31       ` Paolo Bonzini
2014-12-17 21:10 ` [Qemu-devel] [PATCH v5 02/11] fw_cfg: move boards to fw_cfg_init_io() / fw_cfg_init_mem() Laszlo Ersek
2014-12-18 11:18   ` Paolo Bonzini
2014-12-17 21:10 ` [Qemu-devel] [PATCH v5 03/11] fw_cfg_mem: max access size and region size are the same for data register Laszlo Ersek
2014-12-17 21:10 ` [Qemu-devel] [PATCH v5 04/11] fw_cfg_mem: flip ctl_mem_ops and data_mem_ops to DEVICE_BIG_ENDIAN Laszlo Ersek
2014-12-17 21:10 ` [Qemu-devel] [PATCH v5 05/11] exec: allows 8-byte accesses in subpage_ops Laszlo Ersek
2014-12-17 21:10 ` [Qemu-devel] [PATCH v5 06/11] fw_cfg_mem: introduce the "data_width" property Laszlo Ersek
2014-12-17 21:10 ` Laszlo Ersek [this message]
2014-12-17 21:10 ` [Qemu-devel] [PATCH v5 08/11] arm: add fw_cfg to "virt" board Laszlo Ersek
2014-12-17 21:10 ` [Qemu-devel] [PATCH v5 09/11] hw/loader: split out load_image_gzipped_buffer() Laszlo Ersek
2014-12-17 21:10 ` [Qemu-devel] [PATCH v5 10/11] hw/arm: pass pristine kernel image to guest firmware over fw_cfg Laszlo Ersek
2014-12-17 21:10 ` [Qemu-devel] [PATCH v5 11/11] hw/arm/virt: enable passing of EFI-stubbed kernel to guest UEFI firmware Laszlo Ersek
2014-12-18 11:22 ` [Qemu-devel] [PATCH v5 00/11] fw_cfg, bootorder, and UEFI+'-kernel' on arm/virt Paolo Bonzini
2014-12-19  9:39 ` Gerd Hoffmann
2014-12-19  9:52   ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418850613-26821-8-git-send-email-lersek@redhat.com \
    --to=lersek@redhat.com \
    --cc=agraf@suse.de \
    --cc=drjones@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).