qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	mreitz@redhat.com, Stefan Hajnoczi <stefanha@redhat.com>,
	jsnow@redhat.com
Subject: [Qemu-devel] [PATCH v6 0/4] qmp: Add "blockdev-backup"
Date: Thu, 18 Dec 2014 18:37:03 +0800	[thread overview]
Message-ID: <1418899027-8445-1-git-send-email-famz@redhat.com> (raw)

v6: Add Eric's rev-by in 1/4.
    Address minor comments in 2/4, 3/4.
    Add John's rev-by in 3/4.

v5: Address Max's and Markus' comments:
    Split patch 1. (Markus)
    Fix typos and pastos. (Markus, Max)
    Actually acquire aio context. (Max)
    Drop unnecessary initialization of fields in blockdev_backup_prepare. (Max)
    Add "sync" in the document example.
    Add Max's rev-by in patch 4.

The existing drive-backup command accepts a target file path, but that
interface provides little flexibility on the properties of target block device,
compared to what is possible with "blockdev-add", "drive_add" or "-drive".

This is also a building block to allow image fleecing (creating a point in time
snapshot and export with nbd-server-add).

(For symmetry, blockdev-mirror will be added in a separate series.)

Fam


Fam Zheng (4):
  qapi: Comment version info in TransactionAction
  qmp: Add command 'blockdev-backup'
  block: Add blockdev-backup to transaction
  qemu-iotests: Test blockdev-backup in 055

 block/backup.c             |  28 ++++++
 blockdev.c                 | 133 ++++++++++++++++++++++++++++
 qapi-schema.json           |   8 ++
 qapi/block-core.json       |  54 ++++++++++++
 qmp-commands.hx            |  42 +++++++++
 tests/qemu-iotests/055     | 211 +++++++++++++++++++++++++++++++++++++--------
 tests/qemu-iotests/055.out |   4 +-
 7 files changed, 441 insertions(+), 39 deletions(-)

-- 
1.9.3

             reply	other threads:[~2014-12-18 10:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-18 10:37 Fam Zheng [this message]
2014-12-18 10:37 ` [Qemu-devel] [PATCH v6 1/4] qapi: Comment version info in TransactionAction Fam Zheng
2014-12-18 14:33   ` Max Reitz
2014-12-18 10:37 ` [Qemu-devel] [PATCH v6 2/4] qmp: Add command 'blockdev-backup' Fam Zheng
2014-12-18 15:02   ` Max Reitz
2014-12-18 18:07   ` John Snow
2014-12-18 10:37 ` [Qemu-devel] [PATCH v6 3/4] block: Add blockdev-backup to transaction Fam Zheng
2014-12-18 14:44   ` Max Reitz
2014-12-18 10:37 ` [Qemu-devel] [PATCH v6 4/4] qemu-iotests: Test blockdev-backup in 055 Fam Zheng
2014-12-19  8:49 ` [Qemu-devel] [PATCH v6 0/4] qmp: Add "blockdev-backup" Markus Armbruster
2014-12-19  9:50 ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418899027-8445-1-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=armbru@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).