From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1mub-0001KX-He for qemu-devel@nongnu.org; Thu, 18 Dec 2014 21:03:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y1muU-0002pw-Kb for qemu-devel@nongnu.org; Thu, 18 Dec 2014 21:03:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36219) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1muU-0002pZ-DE for qemu-devel@nongnu.org; Thu, 18 Dec 2014 21:03:18 -0500 From: Igor Mammedov Date: Fri, 19 Dec 2014 02:02:13 +0000 Message-Id: <1418954562-13716-19-git-send-email-imammedo@redhat.com> In-Reply-To: <1418954562-13716-1-git-send-email-imammedo@redhat.com> References: <1418954562-13716-1-git-send-email-imammedo@redhat.com> Subject: [Qemu-devel] [RFC 18/47] pc: acpi-build: drop unsupported PM1b_CNT.SLP_TYP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, drjones@redhat.com, claudio.fontana@huawei.com, mst@redhat.com QEMU doesn't implement/advertize PM1b_CNT_BLK register block so do not set/patch its \_Sx values to avoid confusion. Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 3 +-- hw/i386/ssdt-misc.dsl | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 7d32408..b520f4f 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -770,8 +770,7 @@ build_ssdt(GArray *table_data, GArray *linker, if (pm->s4_disabled) { ssdt_ptr[acpi_s4_name[0]] = 'X'; } else { - ssdt_ptr[acpi_s4_pkg[0] + 1] = ssdt_ptr[acpi_s4_pkg[0] + 3] = - pm->s4_val; + ssdt_ptr[acpi_s4_pkg[0] + 1] = pm->s4_val; } patch_pci_windows(pci, ssdt_ptr, sizeof(ssdp_misc_aml)); diff --git a/hw/i386/ssdt-misc.dsl b/hw/i386/ssdt-misc.dsl index 1e3baae..96382a6 100644 --- a/hw/i386/ssdt-misc.dsl +++ b/hw/i386/ssdt-misc.dsl @@ -54,7 +54,7 @@ DefinitionBlock ("ssdt-misc.aml", "SSDT", 0x01, "BXPC", "BXSSDTSUSP", 0x1) ACPI_EXTRACT_NAME_STRING acpi_s3_name Name(_S3, Package(0x04) { One, /* PM1a_CNT.SLP_TYP */ - One, /* PM1b_CNT.SLP_TYP */ + Zero, /* PM1b_CNT.SLP_TYP, QEMU doesn't provide it */ Zero, /* reserved */ Zero /* reserved */ }) @@ -62,7 +62,7 @@ DefinitionBlock ("ssdt-misc.aml", "SSDT", 0x01, "BXPC", "BXSSDTSUSP", 0x1) ACPI_EXTRACT_PKG_START acpi_s4_pkg Name(_S4, Package(0x04) { 0x2, /* PM1a_CNT.SLP_TYP */ - 0x2, /* PM1b_CNT.SLP_TYP */ + Zero, /* PM1b_CNT.SLP_TYP, QEMU doesn't provide it */ Zero, /* reserved */ Zero /* reserved */ }) -- 1.8.3.1