From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com, claudio.fontana@huawei.com, marcel.a@redhat.com
Subject: [Qemu-devel] [PATCH v3 2/8] pc: acpi: decribe bridge device as not hotpluggable
Date: Fri, 19 Dec 2014 11:46:58 +0000 [thread overview]
Message-ID: <1418989624-12049-3-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1418989624-12049-1-git-send-email-imammedo@redhat.com>
when bridge hotplug is disabled, i.e. for machine
types less then 2.0, bridge device was created as
hotpluggable by mistake since commit 133a2da (2.1).
Fix it by just creating it as a present device as
it was done in 1.7.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
hw/i386/acpi-build.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index a4d0c0c..c151fde 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -919,7 +919,7 @@ static void build_pci_bus_end(PCIBus *bus, void *bus_state)
}
}
- if (!dc->hotpluggable || bridge_in_acpi) {
+ if (!dc->hotpluggable || pc->is_bridge) {
clear_bit(slot, slot_hotplug_enable);
}
}
--
1.8.3.1
next prev parent reply other threads:[~2014-12-19 11:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 11:46 [Qemu-devel] [PATCH v3 0/8] pc: acpi: various fixes and cleanups Igor Mammedov
2014-12-19 11:46 ` [Qemu-devel] [PATCH v3 1/8] pc: acpi: fix WindowsXP BSOD when memory hotplug is enabled Igor Mammedov
2014-12-19 11:46 ` Igor Mammedov [this message]
2015-01-19 12:46 ` [Qemu-devel] [PATCH v3 2/8] pc: acpi: decribe bridge device as not hotpluggable Michael S. Tsirkin
2015-01-20 9:22 ` Igor Mammedov
2014-12-19 11:46 ` [Qemu-devel] [PATCH v3 3/8] pc: acpi-build: cleanup AcpiPmInfo initialization Igor Mammedov
2014-12-19 11:47 ` [Qemu-devel] [PATCH v3 4/8] acpi: build_append_nameseg(): add padding if necessary Igor Mammedov
2014-12-19 11:47 ` [Qemu-devel] [PATCH v3 5/8] acpi: move generic aml building helpers into dedictated file Igor Mammedov
2015-01-19 15:08 ` Michael S. Tsirkin
2015-01-20 9:24 ` Igor Mammedov
2015-01-20 9:38 ` Michael S. Tsirkin
2014-12-19 11:47 ` [Qemu-devel] [PATCH v3 6/8] acpi: add build_append_namestring() helper Igor Mammedov
2014-12-19 13:29 ` Claudio Fontana
2014-12-19 14:27 ` [Qemu-devel] [PATCH v4 " Igor Mammedov
2014-12-19 14:45 ` Claudio Fontana
2015-01-28 7:43 ` [Qemu-devel] [PATCH v3 " Michael S. Tsirkin
2015-01-28 12:32 ` Igor Mammedov
2014-12-19 11:47 ` [Qemu-devel] [PATCH v3 7/8] acpi: drop min-bytes in build_package() Igor Mammedov
2015-01-20 9:30 ` Claudio Fontana
2014-12-19 11:47 ` [Qemu-devel] [PATCH v3 8/8] pc: acpi-build: simplify PCI bus tree generation Igor Mammedov
2015-01-19 15:23 ` Michael S. Tsirkin
2015-01-20 9:39 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418989624-12049-3-git-send-email-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=claudio.fontana@huawei.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).