From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y2kbb-00067s-4a for qemu-devel@nongnu.org; Sun, 21 Dec 2014 12:47:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y2kbR-0000gg-K5 for qemu-devel@nongnu.org; Sun, 21 Dec 2014 12:47:47 -0500 Received: from mail.uni-paderborn.de ([131.234.142.9]:49389) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y2kbR-0000ga-DR for qemu-devel@nongnu.org; Sun, 21 Dec 2014 12:47:37 -0500 From: Bastian Koppelmann Date: Sun, 21 Dec 2014 18:47:41 +0000 Message-Id: <1419187669-13576-6-git-send-email-kbastian@mail.uni-paderborn.de> In-Reply-To: <1419187669-13576-1-git-send-email-kbastian@mail.uni-paderborn.de> References: <1419187669-13576-1-git-send-email-kbastian@mail.uni-paderborn.de> Subject: [Qemu-devel] [PULL 05/13] target-tricore: Fix mask handling JNZ.T being 7 bit long List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, alexander.zuepke@hs-rm.de, rth@twiddle.net The mask is actually 7 bit long, instead of 6, so the expression checking for JNZ.T is always false. Let's make the mask 1 bit wider. Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-tricore/translate.c b/target-tricore/translate.c index 3d87346..8f9e13e 100644 --- a/target-tricore/translate.c +++ b/target-tricore/translate.c @@ -3828,8 +3828,8 @@ static void decode_32Bit_opc(CPUTriCoreState *env, DisasContext *ctx) op1 = MASK_OP_MAJOR(ctx->opcode); - /* handle JNZ.T opcode only being 6 bit long */ - if (unlikely((op1 & 0x3f) == OPCM_32_BRN_JTT)) { + /* handle JNZ.T opcode only being 7 bit long */ + if (unlikely((op1 & 0x7f) == OPCM_32_BRN_JTT)) { op1 = OPCM_32_BRN_JTT; } -- 2.2.1