qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: peter.maydell@linaro.org, qemu-devel@nongnu.org,
	rjones@redhat.com, drjones@redhat.com, lersek@redhat.com,
	agraf@suse.de
Subject: [Qemu-devel] [PATCH v6 03/11] fw_cfg_mem: max access size and region size are the same for data register
Date: Mon, 22 Dec 2014 13:11:37 +0100	[thread overview]
Message-ID: <1419250305-31062-4-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1419250305-31062-1-git-send-email-pbonzini@redhat.com>

From: Laszlo Ersek <lersek@redhat.com>

Make it clear that the maximum access size to the MMIO data register
determines the full size of the memory region.

Currently the max access size is 1.

This patch doesn't change behavior.

Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/nvram/fw_cfg.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
index c48bc6e..8deb860 100644
--- a/hw/nvram/fw_cfg.c
+++ b/hw/nvram/fw_cfg.c
@@ -31,7 +31,6 @@
 #include "qemu/config-file.h"
 
 #define FW_CFG_SIZE 2
-#define FW_CFG_DATA_SIZE 1
 #define FW_CFG_NAME "fw_cfg"
 #define FW_CFG_PATH "/machine/" FW_CFG_NAME
 
@@ -694,7 +693,8 @@ static void fw_cfg_mem_realize(DeviceState *dev, Error **errp)
     sysbus_init_mmio(sbd, &s->ctl_iomem);
 
     memory_region_init_io(&s->data_iomem, OBJECT(s), &fw_cfg_data_mem_ops,
-                          FW_CFG(s), "fwcfg.data", FW_CFG_DATA_SIZE);
+                          FW_CFG(s), "fwcfg.data",
+                          fw_cfg_data_mem_ops.valid.max_access_size);
     sysbus_init_mmio(sbd, &s->data_iomem);
 }
 
-- 
2.1.0

  parent reply	other threads:[~2014-12-22 12:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-22 12:11 [Qemu-devel] [PATCH v6 00/11] fw_cfg, bootorder, and UEFI+'-kernel' on arm/virt Paolo Bonzini
2014-12-22 12:11 ` [Qemu-devel] [PATCH v6 01/11] fw_cfg: hard separation between the MMIO and I/O port mappings Paolo Bonzini
2014-12-22 12:11 ` [Qemu-devel] [PATCH v6 02/11] fw_cfg: move boards to fw_cfg_init_io() / fw_cfg_init_mem() Paolo Bonzini
2014-12-22 12:11 ` Paolo Bonzini [this message]
2014-12-22 12:11 ` [Qemu-devel] [PATCH v6 04/11] fw_cfg_mem: flip ctl_mem_ops and data_mem_ops to DEVICE_BIG_ENDIAN Paolo Bonzini
2014-12-22 12:11 ` [Qemu-devel] [PATCH v6 05/11] exec: allows 8-byte accesses in subpage_ops Paolo Bonzini
2014-12-22 12:11 ` [Qemu-devel] [PATCH v6 06/11] fw_cfg_mem: introduce the "data_width" property Paolo Bonzini
2014-12-22 12:11 ` [Qemu-devel] [PATCH v6 07/11] fw_cfg_mem: expose the "data_width" property with fw_cfg_init_mem_wide() Paolo Bonzini
2014-12-22 12:11 ` [Qemu-devel] [PATCH v6 08/11] arm: add fw_cfg to "virt" board Paolo Bonzini
2014-12-22 12:11 ` [Qemu-devel] [PATCH v6 09/11] hw/loader: split out load_image_gzipped_buffer() Paolo Bonzini
2014-12-22 12:11 ` [Qemu-devel] [PATCH v6 10/11] hw/arm: pass pristine kernel image to guest firmware over fw_cfg Paolo Bonzini
2014-12-22 12:11 ` [Qemu-devel] [PATCH v6 11/11] hw/arm/virt: enable passing of EFI-stubbed kernel to guest UEFI firmware Paolo Bonzini
2014-12-22 23:41 ` [Qemu-devel] [PATCH v6 00/11] fw_cfg, bootorder, and UEFI+'-kernel' on arm/virt Peter Maydell
2014-12-23 22:17 ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1419250305-31062-4-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=agraf@suse.de \
    --cc=drjones@redhat.com \
    --cc=lersek@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).