From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH 3/5] target-sparc: is_translating_asi() is TARGET_SPARC64 only
Date: Tue, 23 Dec 2014 22:11:19 +0000 [thread overview]
Message-ID: <1419372681-17504-4-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1419372681-17504-1-git-send-email-peter.maydell@linaro.org>
Move the is_translating_asi() inside the TARGET_SPARC64 ifdef (and remove
the unimplemented 32-bit codepath), as it is only called from TARGET_SPARC64
code. This fixes a clang 3.4 unused-function warning.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <rth@twiddle.net>
---
target-sparc/ldst_helper.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/target-sparc/ldst_helper.c b/target-sparc/ldst_helper.c
index 42b80cb..f27e0a6 100644
--- a/target-sparc/ldst_helper.c
+++ b/target-sparc/ldst_helper.c
@@ -262,11 +262,12 @@ static inline target_ulong address_mask(CPUSPARCState *env1, target_ulong addr)
}
#endif
+#ifdef TARGET_SPARC64
/* returns true if access using this ASI is to have address translated by MMU
otherwise access is to raw physical address */
+/* TODO: check sparc32 bits */
static inline int is_translating_asi(int asi)
{
-#ifdef TARGET_SPARC64
/* Ultrasparc IIi translating asi
- note this list is defined by cpu implementation
*/
@@ -283,13 +284,8 @@ static inline int is_translating_asi(int asi)
default:
return 0;
}
-#else
- /* TODO: check sparc32 bits */
- return 0;
-#endif
}
-#ifdef TARGET_SPARC64
static inline target_ulong asi_address_mask(CPUSPARCState *env,
int asi, target_ulong addr)
{
--
1.9.1
next prev parent reply other threads:[~2014-12-23 22:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 22:11 [Qemu-devel] [PATCH 0/5] SPARC: fix clang warnings Peter Maydell
2014-12-23 22:11 ` [Qemu-devel] [PATCH 1/5] target-sparc: Remove unused gen_op_subi_cc and gen_op_addi_cc Peter Maydell
2014-12-23 22:11 ` [Qemu-devel] [PATCH 2/5] target-sparc: address_mask(), asi_address_mask() are TARGET_SPARC64 only Peter Maydell
2014-12-23 22:11 ` Peter Maydell [this message]
2014-12-23 22:11 ` [Qemu-devel] [PATCH 4/5] target-sparc: Mark gen_load_trap_state_at_tl() as !CONFIG_USER_ONLY Peter Maydell
2014-12-23 22:11 ` [Qemu-devel] [PATCH 5/5] disas/sparc: Remove unused data sparc_opcode_archs[] Peter Maydell
2015-01-02 13:57 ` [Qemu-devel] [PATCH 0/5] SPARC: fix clang warnings Mark Cave-Ayland
2015-01-02 17:30 ` Peter Maydell
2015-01-18 21:15 ` Mark Cave-Ayland
2015-01-21 16:16 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419372681-17504-4-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).