From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55749) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y3Xv0-0007eA-0z for qemu-devel@nongnu.org; Tue, 23 Dec 2014 17:27:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y3Xuq-0001z3-Po for qemu-devel@nongnu.org; Tue, 23 Dec 2014 17:27:05 -0500 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:54639) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y3Xuq-0001yk-Ic for qemu-devel@nongnu.org; Tue, 23 Dec 2014 17:26:56 -0500 From: Peter Maydell Date: Tue, 23 Dec 2014 22:26:55 +0000 Message-Id: <1419373615-17989-4-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1419373615-17989-1-git-send-email-peter.maydell@linaro.org> References: <1419373615-17989-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH 3/3] migration/qemu-file.c: Don't shift left into sign bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org Add a cast in qemu_get_be32() to avoid shifting left into the sign bit of a signed integer (which is undefined behaviour in C). Signed-off-by: Peter Maydell --- migration/qemu-file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index d2d4007..a7f2a34 100644 --- a/migration/qemu-file.c +++ b/migration/qemu-file.c @@ -503,7 +503,7 @@ unsigned int qemu_get_be16(QEMUFile *f) unsigned int qemu_get_be32(QEMUFile *f) { unsigned int v; - v = qemu_get_byte(f) << 24; + v = (unsigned int)qemu_get_byte(f) << 24; v |= qemu_get_byte(f) << 16; v |= qemu_get_byte(f) << 8; v |= qemu_get_byte(f); -- 1.9.1